Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lightbox issue with alignment control #4297

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

girishpanchal30
Copy link
Contributor

Summary

Fixed issue with WP default lightbox model.

Test instructions

  1. Add an image block
  2. enable “Expand on click” for the image
  3. change the alignment of the image ( left/right/center) -> when an alignment option (other than None ) is enabled, the image doesn't expand to full width

Check before Pull Request is ready:

Closes #4260

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 2, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 2, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Sep 2, 2024

Plugin build for 9afa3f4 is ready 🛎️!

@rodica-andronache
Copy link
Contributor

tested and it's working well 👍

@selul
Copy link
Contributor

selul commented Sep 2, 2024

@girishpanchal30 we are not looking to increase the CSS limit so please review the solution within the boundaries.

@girishpanchal30
Copy link
Contributor Author

@selul I've added an inline style instead of adding CSS in the main style.

@rodica-andronache
Copy link
Contributor

tested and it's still working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants