Quaternion conversions #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to_euler() contained the doc string of from_euler.
* 'euler' -> 'Euler'
* Given existence of from_axis_angle(), and conversion to to_euler(), and matrix(), a method for conversion to axis angle representation is missing.
* Consistently with other functions, use self.data instead of self.q
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #77 will not alter performanceComparing Summary
|
coco-speed
force-pushed
the
main
branch
7 times, most recently
from
d645a84
to
77ce42f
Compare
coco-speed
force-pushed
the
main
branch
2 times, most recently
from
0b2b340
to
dd0cff2
Compare
coco-speed
force-pushed
the
main
branch
5 times, most recently
from
3047a1c
to
e79ad64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically by CodSpeed to track performance changes of the pull request kornia/kornia#2993.
The original branch is fork-2993-tjelinek/quaternion-conversions