Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My first entry #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

My first entry #19

wants to merge 3 commits into from

Conversation

sarampcarvalho
Copy link
Contributor

hysterectomy

hysterectomy
Copy link
Member

@ttasovac ttasovac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work Sara! I have some small suggestions for improvement.

<entry xml:id="DicEndo.hysterectomy" xml:lang="en">
<form type="lemma">
<orth>Hysterectomy</orth>
<pron><pc>/</pc>ˌhɪstəˈrektəmi<pc>/</pc></pron>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put <pc> outside of <pron> because those slashes function as delimiters but they are themselves not part of the pronunciation

Also, you could add the attribute notation to indicate that this is ipa like this <pron notation="IPA"></pron>

<gramGrp>
<gram type="pos">noun</gram>
</gramGrp>
<etym type="inheritance">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we said yesterday after class, probably a borrowing 😄

<gram type="pos">noun</gram>
</gramGrp>
<etym type="inheritance">
<cit type="etymon" xml:lang="el"><form><orth>hystéra</orth></form></cit>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's etymology, then it's probably from Ancient and not Modern Greek. And if it's the former, the language code should be "grc".

<lbl>and</lbl>
<cit type="etymon" xml:lang="el"><form><orth>ektomia</orth></form></cit>
</etym>
<cit type="translationEquivalent">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done! you must have found this yourself in the messy TEI Lex-0 Guidelines 👌

<cit type="etymon" xml:lang="el"><form><orth>ektomia</orth></form></cit>
</etym>
<cit type="translationEquivalent">
<form xml:lang="fr">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in TEI Lex-0, we put the xml:lang on the container, i.e. on cit type translationEquivalent. That may not be clear in the guidelines yet. I totally see why you would want to put in on <form> so I personally wouldn't consider it a "mistake". We may want to push TEI Lex-0 to decide whether this is allowed or not.

<sense xml:id="DicEndo.hysterectomy.1">
<def>Surgical removal of the uterus.</def>
<!--note is not allowed, but I'm not sure that dictScrap is expressive enough.-->
<note>When the ovaries and the fallopian tubes are also removed, it is called hysterectomy with bilateral
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you merge from upstream, note will no longer be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants