Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover Collection View: Call appearance methods on cells #2238

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+21 −1
Open

Discover Collection View: Call appearance methods on cells #2238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion podcasts/DiscoverCellType.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ enum DiscoverCellType: CaseIterable {
}

vc.registerDiscoverDelegate(delegate)
vc.populateFrom(item: item.item, region: item.region, category: item.selectedCategory)
}
}
}
Expand Down
21 changes: 21 additions & 0 deletions podcasts/DiscoverCollectionViewController+Search.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,27 @@ extension DiscoverCollectionViewController: UICollectionViewDelegate {

searchController.parentScrollViewDidScroll(scrollView)
}

func collectionView(_ collectionView: UICollectionView, willDisplay cell: UICollectionViewCell, forItemAt indexPath: IndexPath) {
let item = dataSource.itemIdentifier(for: indexPath)

switch item {
case .item(let item):
let viewController = (cell.contentConfiguration as? UIViewControllerContentConfiguration)?.viewController as? DiscoverSummaryProtocol & UIViewController
viewController?.populateFrom(item: item.item, region: item.region, category: item.selectedCategory)
viewController?.beginAppearanceTransition(true, animated: false)
viewController?.endAppearanceTransition()
default:
()
}
}

func collectionView(_ collectionView: UICollectionView, didEndDisplaying cell: UICollectionViewCell, forItemAt indexPath: IndexPath) {

let viewController = (cell.contentConfiguration as? UIViewControllerContentConfiguration)?.viewController
viewController?.beginAppearanceTransition(false, animated: false)
viewController?.endAppearanceTransition()
}
}

extension DiscoverCollectionViewController: PCSearchBarDelegate {
Expand Down
Loading