Discover Collection View: Call appearance methods on cells #2238
+21
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the Discover collection view cells to call
viewWillAppear
,viewDidAppear
,viewWillDisappear
, andviewDidDisappear
(indirectly viabeginAppearanceTransition
andendAppearanceTransition
) when the cell is shown or hidden according to UICollectionView delegate methods. This behavior reuses our existing code for each Discover view controller which loads content, triggers analytics events, and handles some timer additions (for the Featured Summary cell).To test
tracksLogging
discover_list_impression
event is called when a cell is just about to be shown.discover_featured_page_changed
event is not being logged while in a categorydiscover_featured_page_changed
event is logged againChecklist
CHANGELOG.md
if necessary.