Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover Collection View: Call appearance methods on cells #2238

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Oct 3, 2024

📘 Part of: #2104

Modifies the Discover collection view cells to call viewWillAppear, viewDidAppear, viewWillDisappear, and viewDidDisappear (indirectly via beginAppearanceTransition and endAppearanceTransition) when the cell is shown or hidden according to UICollectionView delegate methods. This behavior reuses our existing code for each Discover view controller which loads content, triggers analytics events, and handles some timer additions (for the Featured Summary cell).

To test

  1. Enable tracksLogging
  2. Navigate to Discover
  3. Verify that the discover_list_impression event is called when a cell is just about to be shown.
  4. Ensure that cells are correctly loaded
  5. Navigate to a category
  6. Ensure that the discover_featured_page_changed event is not being logged while in a category
  7. Close the category
  8. Ensure that the discover_featured_page_changed event is logged again

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus requested a review from a team as a code owner October 3, 2024 23:35
@bjtitus bjtitus requested review from danielebogo and removed request for a team October 3, 2024 23:35
@bjtitus bjtitus added this to the 7.75 milestone Oct 3, 2024
@bjtitus bjtitus changed the title Updates the Discover Collection View to call VC methods Discover Collection View: Call appearance methods on cells Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant