-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small simplifications (redo) #3250
Open
Zearin
wants to merge
18
commits into
11ty:main
Choose a base branch
from
Zearin:refactor/small-simplifications-redo
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c9b06d - Browse repository at this point
Copy the full SHA 6c9b06dView commit details -
Some tweaks to (hopefully) make some loops a little faster to grok
Configuration menu - View commit details
-
Copy full SHA for 0434dda - Browse repository at this point
Copy the full SHA 0434ddaView commit details -
A little use of the newer optional chaning operator to make some repetetive conditionals slightly faster to read.
Configuration menu - View commit details
-
Copy full SHA for 0f94894 - Browse repository at this point
Copy the full SHA 0f94894View commit details -
Some targeted use of `.some()` and `.includes()` to convey the intention in compact fashion.
Configuration menu - View commit details
-
Copy full SHA for 5db9af4 - Browse repository at this point
Copy the full SHA 5db9af4View commit details -
Some rewrites involving `Set`s, often involved in making it easier to grok what’s populating the set at a glance.
Configuration menu - View commit details
-
Copy full SHA for b1949d6 - Browse repository at this point
Copy the full SHA b1949d6View commit details -
misc: Shorter
.map()
,.filter()
, etc.The standard functional tools for manipulating Arrays (usually `.map()` and `.filter()`) make it easy to write some code that reads a little bit like a pipeline. Some small rewrites can make these even easier to read. If the arrow function is short enough, using the single-line syntax can make it less noisy by avoiding the need for braces `{`|`}` or `return`. Using the static methods _directly_ for the callback is even better, since it’s not even necessary to use an anonymous arrow function or name any arguments.
Configuration menu - View commit details
-
Copy full SHA for 5752478 - Browse repository at this point
Copy the full SHA 5752478View commit details -
Configuration menu - View commit details
-
Copy full SHA for b20ae40 - Browse repository at this point
Copy the full SHA b20ae40View commit details -
misc: Remove superfluous array
As I have recently learned, `Object.values()` already returns an Array. :D
Configuration menu - View commit details
-
Copy full SHA for 994194c - Browse repository at this point
Copy the full SHA 994194cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9c2596 - Browse repository at this point
Copy the full SHA c9c2596View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89dfd18 - Browse repository at this point
Copy the full SHA 89dfd18View commit details -
misc: Begin loop with pre-transformed array
(Rather than decide between using `target` or `path` in the loop body, I just smooshed them together.)
Configuration menu - View commit details
-
Copy full SHA for 600413c - Browse repository at this point
Copy the full SHA 600413cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8de0bc - Browse repository at this point
Copy the full SHA b8de0bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3b9ed - Browse repository at this point
Copy the full SHA ca3b9edView commit details
Commits on Apr 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 73373b5 - Browse repository at this point
Copy the full SHA 73373b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ec09fd - Browse repository at this point
Copy the full SHA 0ec09fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2289045 - Browse repository at this point
Copy the full SHA 2289045View commit details -
Configuration menu - View commit details
-
Copy full SHA for b560804 - Browse repository at this point
Copy the full SHA b560804View commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2f0273a - Browse repository at this point
Copy the full SHA 2f0273aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.