Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small simplifications (redo) #3250

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Commits on Apr 13, 2024

  1. Configuration menu
    Copy the full SHA
    6c9b06d View commit details
    Browse the repository at this point in the history
  2. misc: Loop love

    Some tweaks to (hopefully) make some loops a little faster to grok
    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    0434dda View commit details
    Browse the repository at this point in the history
  3. misc: Terser conditionals

    A little use of the newer optional chaning operator to make some repetetive conditionals slightly faster to read.
    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    0f94894 View commit details
    Browse the repository at this point in the history
  4. misc: .some() and .includes()

    Some targeted use of `.some()` and `.includes()` to convey the intention in compact fashion.
    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    5db9af4 View commit details
    Browse the repository at this point in the history
  5. misc: For my next Set(…)

    Some rewrites involving `Set`s, often involved in making it easier to grok what’s populating the set at a glance.
    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    b1949d6 View commit details
    Browse the repository at this point in the history
  6. misc: Shorter .map(), .filter(), etc.

    The standard functional tools for manipulating Arrays (usually `.map()` and `.filter()`) make it easy to write some code that reads a little bit like a pipeline.
    
    Some small rewrites can make these even easier to read. If the arrow function is short enough, using the single-line syntax can make it less  noisy by avoiding the need for braces `{`|`}` or `return`.
    
    Using the static methods _directly_ for the callback is even better, since it’s not even necessary to use an anonymous arrow function or name any arguments.
    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    5752478 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b20ae40 View commit details
    Browse the repository at this point in the history
  8. misc: Remove superfluous array

    As I have recently learned, `Object.values()` already returns an Array. :D
    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    994194c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c9c2596 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    89dfd18 View commit details
    Browse the repository at this point in the history
  11. misc: Begin loop with pre-transformed array

    (Rather than decide between using `target` or `path` in the loop body, I just smooshed them together.)
    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    600413c View commit details
    Browse the repository at this point in the history
  12. misc: More terser conditionals

    Zearin committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    b8de0bc View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ca3b9ed View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. misc: More terser conditionals

    Zearin committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    73373b5 View commit details
    Browse the repository at this point in the history
  2. misc: Replace unique()

    Zearin committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    0ec09fd View commit details
    Browse the repository at this point in the history
  3. misc: More terser .map()

    Zearin committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    2289045 View commit details
    Browse the repository at this point in the history
  4. misc: More terser conditionals

    Zearin committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    b560804 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    2f0273a View commit details
    Browse the repository at this point in the history