Small simplifications (redo) #3250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tweaks to (hopefully) make some loops a little faster to grok
A little use of the newer optional chaning operator to make some repetetive conditionals slightly faster to read.
Some targeted use of `.some()` and `.includes()` to convey the intention in compact fashion.
Some rewrites involving `Set`s, often involved in making it easier to grok what’s populating the set at a glance.
The standard functional tools for manipulating Arrays (usually `.map()` and `.filter()`) make it easy to write some code that reads a little bit like a pipeline.
Some small rewrites can make these even easier to read. If the arrow function is short enough, using the single-line syntax can make it less noisy by avoiding the need for braces `{`|`}` or `return`.
Using the static methods _directly_ for the callback is even better, since it’s not even necessary to use an anonymous arrow function or name any arguments.
As I have recently learned, `Object.values()` already returns an Array. :D
(Rather than decide between using `target` or `path` in the loop body, I just smooshed them together.)
chee
reviewed
Apr 16, 2024
src/Data/TemplateData.js
Outdated
| @@ -599,7 +598,7 @@ class TemplateData { | |||
| } | |||
|
|
|||
| debug("getLocalDataPaths(%o): %o", templatePath, paths); | |||
| return unique(paths).reverse(); | |||
| return [...new Set(paths)].reverse(); | |||
There was a problem hiding this comment.
i'm not sure this javascript incantation is necessarily easier to understand than a named function
There was a problem hiding this comment.
Also - looks like this is exactly what the unique function is/was doing already anyway! Might as well use the function for readability me thinks. https://github.com/11ty/eleventy/blob/main/src/Util/Unique.js
There was a problem hiding this comment.
True. I’m all over the place :( I will fix this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a redo of #3243, after I did something stupid in Git and messed up the branch history. (😮!)
These are an assortment of small tweaks.
My goal was to make these bits of code easier to understand at a glance. There’s plenty of subjectivity in that, to be sure.
Some of these make use of Javascript features that were not available a few years ago. (Both syntax and APIs of built-in objects.) Hopefully, I applied them in a way that makes it easier to understand each block of code. Since Eleventy v3 is still in alpha, I thought this would be a good time to introduce them, since they are supported pretty much everywhere and a major version increment doesn’t have to worry about breaking compatibility.