Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the scrapy-poet config #28

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Update the scrapy-poet config #28

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7479950
Update the scrapy-poet config
Gallaecio Dec 19, 2024
981a25f
Account for scrapy-poet settings configured by the scrapy-zyte-api ad…
Gallaecio Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion zyte_spider_templates_project/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,15 @@
"duplicate_url_discarder.Addon": 600,
"zyte_spider_templates.Addon": 700,
}

DOWNLOADER_MIDDLEWARES = {
"scrapy_poet.InjectionMiddleware": 543,
"scrapy.downloadermiddlewares.stats.DownloaderStats": None,
"scrapy_poet.DownloaderStatsMiddleware": 850,
}
SPIDER_MIDDLEWARES = {
"scrapy_poet.RetryMiddleware": 275,
}
REQUEST_FINGERPRINTER_CLASS = "scrapy_poet.ScrapyPoetRequestFingerprinter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This interacts both with the duplicate url discarder and with scrapy-zyte-api (see https://github.com/zytedata/duplicate-url-discarder/blob/d6920865039db10d1eb0a6763d1fa3be20e3469b/duplicate_url_discarder/_addon.py#L26 and https://github.com/scrapy-plugins/scrapy-zyte-api/blob/cc3cfddcd5e38502d7cda211178aafcd0a8863d5/scrapy_zyte_api/addon.py#L76).

I don't expect any issues, but we should check somehow that it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on a test for it, I found out it was working as expected before this change. It’s because the scrapy-zyte-api fingerprinter already uses the scrapy-poet one as fallback if scrapy-poet is installed. So this line is unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a related note, the scrapy-zyte-api add-on also configures the injection middleware,


# scrapy-poet
SCRAPY_POET_DISCOVER = [
Expand Down