Add rating_processor. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 8 9 +1
Lines 1342 1395 +53
=====================================
- Misses 1342 1395 +53
|
Gallaecio
reviewed
Jan 25, 2024
Gallaecio
reviewed
Jan 25, 2024
Gallaecio
reviewed
Jan 25, 2024
Gallaecio
approved these changes
Jan 25, 2024
kmike
reviewed
Jan 25, 2024
tests/test_processors.py
Outdated
| ), | ||
| ( | ||
| Selector(text="<html>3.8 out of 10 (5 reviews)</html>"), | ||
| AggregateRating(ratingValue=3.8, reviewCount=5), |
There was a problem hiding this comment.
It seems we should have it as xfail test, as bestRating=10 is not extracted
kmike
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some additional ideas for the processor so it will be a draft for now.
Requires zytedata/zyte-parsers#13