Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide extractors #69

Merged
merged 14 commits into from
Jan 24, 2024
Merged

Provide extractors #69

merged 14 commits into from
Jan 24, 2024

Conversation

Gallaecio
Copy link
Contributor

No description provided.

@Gallaecio Gallaecio marked this pull request as ready for review December 20, 2023 06:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023 •
edited
Loading

Codecov Report

Merging #69 (e2cea65) into main (347b851) will not change coverage.
The diff coverage is 0.00%.

❗ Current head e2cea65 differs from pull request most recent head 8d57a99. Consider uploading reports for the commit 8d57a99 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main     #69   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          8       9    +1     
  Lines       1342    1363   +21     
=====================================
- Misses      1342    1363   +21
Files Coverage Δ
zyte_common_items/items.py 0.00% <ø> (ø)
zyte_common_items/__init__.py 0.00% <0.00%> (ø)
zyte_common_items/extractors.py 0.00% <0.00%> (ø)

@Gallaecio Gallaecio requested review from kmike, wRAR and BurnzZ December 20, 2023 06:41
Gallaecio
Gallaecio commented Dec 20, 2023
View reviewed changes
tests/test_extractors.py Outdated Show resolved Hide resolved
@wRAR wRAR mentioned this pull request Dec 25, 2023
Merged
BurnzZ
BurnzZ reviewed Dec 26, 2023
View reviewed changes
tests/test_extractors.py Outdated Show resolved Hide resolved
@wRAR wRAR mentioned this pull request Jan 8, 2024
Merged
kmike
kmike reviewed Jan 24, 2024
View reviewed changes
tests/test_pages_price.py Outdated Show resolved Hide resolved
@kmike kmike merged commit 8c5d3ca into zytedata:main Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnzZ BurnzZ BurnzZ approved these changes

@wRAR wRAR wRAR approved these changes

@kmike kmike kmike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gallaecio @codecov-commenter @kmike @wRAR @BurnzZ