settings: Fix action column in users table.

[dhruv-goyal-10]

Fixed #29894

Fixes: Action column in users & deactivated users table.

[zulipbot]

Hello @zulip/server-settings members, this pull request was labeled with the "area: settings UI" label, so you may want to check it out!

[dhruv-goyal-10]

You can have a look at the updated UI here.

Screen.Recording.2024-05-07.at.8.06.37.PM.mov

[alya]

Thanks for the fix! Please complete the self-review checklist (as applicable), and post a comment to request a review when ready.

[alya]

How is the issue you noted in #29894 (comment) handled?

[dhruv-goyal-10]

How is the issue you noted in #29894 (comment) handled?

So, Initially whether to show last_active_date in row or not depended on the attribute is_active.

But, now I created an explicit attribute named as display_last_active_in_table which I am setting to true in case of Users Table and setting it to false in case of Deactivated Users Table.

So, now last_active_date will be visible in Users Table always and will never be visible in Deactivated Users Table irrespective of whether user is active or not.

[dhruv-goyal-10]

@alya Can you have a look at this PR?

Thanks.