Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input_pill: Add test for input event handler. #29933

Merged
merged 1 commit into from
May 20, 2024

Conversation

Lalit3716
Copy link
Collaborator

Added a test for newly added input event handler for input_pill.ts module.

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@Lalit3716 Lalit3716 changed the title input_pill: Add test for event handler. input_pill: Add test for input event handler. May 3, 2024
@zulipbot zulipbot added size: M and removed size: S labels May 3, 2024
@Lalit3716
Copy link
Collaborator Author

This is ready for another look, I modified the test a little bit according to this comment. I am open to more suggestions around this test since I am still not sure if that's correct way to test this.

@timabbott timabbott added the integration review Added by maintainers when a PR may be ready for integration. label May 16, 2024
@timabbott timabbott merged commit 5ea98cb into zulip:main May 20, 2024
7 checks passed
@timabbott
Copy link
Sponsor Member

Sure, this works, merged, thanks @Lalit3716!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when a PR may be ready for integration. size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants