Switch/Add servers without logging in/out #51

kunall17 · 2016-04-17T11:13:18Z

Developed #47 and also fixes #1

Ability to add your own server
Give a name to the server you are saving.
Ability to add new servers
Switch between these servers/user accounts.

Screenshots:

This saves the newly added servers in a new sharedPreference, hence saving their api_key which is further used for the authentication!

smarx · 2016-04-17T11:13:20Z

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

ryansnowboarder · 2016-04-19T15:40:45Z

Hey bro,

I'm having problems connecting zulip/zulip-android/master branch to my localhost with the login hack for [email protected]. Does your code connect to localhost without any problems?

I'll fork it if I don't hear a response within the next few hours and try it myself - I just thought I would ask the most knowledgeable person first.

kunall17 · 2016-04-20T01:33:14Z

@ryansnowboarder problems as in? your server URL is not taken or you cannot sign in?
I haven't tested with the iago hack, And if you are talking about forking this branch then i have commented out the IAGO hack as there's no point of having it anymore because you have to specify the server now.

And sorry, I am not the most knowledgeable person here.

ryansnowboarder · 2016-04-20T17:54:33Z

My problem is that my local hosted Zulip server does not respond to HTTP
Requests from the app on the Android Emulator and an Android device. Works
fine with curl from the command prompt though. I've tried allowing
everything through the firewall while sending a request and that didn't fix
it. I tried connecting to the Zulip server from the browser from the
browser and device, which showed a socket error.

I ran out of time and didn't fork your repo, but I'll do that soon to see
if it works.

On Tue, Apr 19, 2016 at 9:33 PM, Kunal Gupta [email protected]
wrote:

@ryansnowboarder https://github.com/ryansnowboarder problems as in?
your server URL is not taken or you cannot sign in?
I haven't tested with the iago hack.

And sorry, I am not the most knowledgeable person here.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#51 (comment)

niftynei · 2016-05-10T13:32:38Z

@kunall17 if it's not too much trouble, do you mind rebasing this against master?

kunall17 · 2016-06-27T18:45:25Z

@niftynei rebased and updated this branch! :)

niftynei · 2016-07-19T00:27:19Z

@kunall17 what's the status of this PR?

niftynei · 2016-08-12T18:48:56Z

app/src/main/java/com/zulip/android/ZulipApp.java

+            username = you.getEmail();
+        } catch (Exception e) {
+            //SQL Exception can occur if name is not updated!
+            ZLog.logException(e);


In what cases would username be null?

It shouldn't be, as setEmail is being called always before this is called!

niftynei · 2016-08-12T19:32:33Z

Hello kunal. I wasn't able to try this out because of the merge conflicts, but I left some notes on the code. Thanks!

niftynei · 2016-08-16T18:00:30Z

@kunall17 I got a crash when I successfully logged into a second realm.

08-16 13:59:17.490 E/AndroidRuntime(10928): FATAL EXCEPTION: main
08-16 13:59:17.490 E/AndroidRuntime(10928): Process: com.zulip.android.dev, PID: 10928
08-16 13:59:17.490 E/AndroidRuntime(10928): java.lang.RuntimeException: java.sql.SQLException: Unable to run insert stmt on object com.zulip.android.models.Stream@2275a78e: INSERT INTO `streams` (`color` ,`inHomeView` ,`inviteOnly` ,`name` ,`subscribed` ) VALUES (?,?,?,?,?)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at com.j256.ormlite.dao.RuntimeExceptionDao.createIfNotExists(RuntimeExceptionDao.java:240)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at com.zulip.android.models.Stream.getByName(Stream.java:138)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at com.zulip.android.activities.ZulipActivity$20.setViewValue(ZulipActivity.java:690)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.SimpleCursorTreeAdapter.bindView(SimpleCursorTreeAdapter.java:220)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.SimpleCursorTreeAdapter.bindGroupView(SimpleCursorTreeAdapter.java:264)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.CursorTreeAdapter.getGroupView(CursorTreeAdapter.java:207)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.ExpandableListConnector.getView(ExpandableListConnector.java:446)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.AbsListView.obtainView(AbsListView.java:2346)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.ListView.makeAndAddView(ListView.java:1876)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.ListView.fillSpecific(ListView.java:1355)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.ListView.layoutChildren(ListView.java:1663)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.AbsListView.onLayout(AbsListView.java:2148)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.View.layout(View.java:16636)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewGroup.layout(ViewGroup.java:5437)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.support.v4.widget.DrawerLayout.onLayout(DrawerLayout.java:1215)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.View.layout(View.java:16636)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewGroup.layout(ViewGroup.java:5437)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.View.layout(View.java:16636)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewGroup.layout(ViewGroup.java:5437)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1735)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1579)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.LinearLayout.onLayout(LinearLayout.java:1488)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.View.layout(View.java:16636)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewGroup.layout(ViewGroup.java:5437)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.View.layout(View.java:16636)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewGroup.layout(ViewGroup.java:5437)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1735)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1579)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.LinearLayout.onLayout(LinearLayout.java:1488)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.View.layout(View.java:16636)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewGroup.layout(ViewGroup.java:5437)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at com.android.internal.policy.PhoneWindow$DecorView.onLayout(PhoneWindow.java:2678)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.View.layout(View.java:16636)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewGroup.layout(ViewGroup.java:5437)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2179)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1939)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1115)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6023)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.Choreographer$CallbackRecord.run(Choreographer.java:858)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.Choreographer.doCallbacks(Choreographer.java:670)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.Choreographer.doFrame(Choreographer.java:606)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.os.Handler.handleCallback(Handler.java:739)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.os.Handler.dispatchMessage(Handler.java:95)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.os.Looper.loop(Looper.java:148)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at android.app.ActivityThread.main(ActivityThread.java:5422)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at java.lang.reflect.Method.invoke(Native Method)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
08-16 13:59:17.490 E/AndroidRuntime(10928):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
08-16 13:59:17.490 E/AndroidRuntime(10928): Caused by: java.sql.SQLException: Unable to run insert stmt on object com.zulip.android.models.Stream@2275a78e: INSERT INTO `streams` (`color` ,`inHomeView` ,`inviteOnly` ,`name` ,`subscribed` ) VALUES (?,

kunall17 · 2016-08-16T20:06:53Z

If you used the DevAuthBackEnd in the second login attempt (when adding realm) then this should fix the error!

niftynei · 2016-08-16T22:05:07Z

it seems to work ok now, is there some context for why this occurs? otherwise it looks really good and i'd love to get it merged in 👍

cc @kunall17 :)

kunall17 · 2016-08-17T03:23:59Z

If you had tried devAuthBackEnd then this error seems valid before the fix, otherwise it shouldn't occur!
Never encountered this error!
Updated the branch as well!

niftynei · 2016-08-22T20:45:42Z

app/src/main/java/com/zulip/android/activities/LoginActivity.java

+        realmNameET = (EditText) findViewById(R.id.realmName);
+        if (getIntent().getBooleanExtra("FROM_ADDREALM", false)) {
+            startedFromAddRealm = true;
+            ((TextView) findViewById(R.id.textView1)).setText(R.string.add_realm);


@kunall17 this is possibly a rebasing error, but i can't get my version of this to compile because it can't find the textView1 view.

This GlobalSettings will store all the info about the saved realms.

Changes the database helper and save default settings for the server.

Saves current server position, changes the databaseHelper and get's the saved data for this server

Abort current connections, handlers and establish new ones.

…lip Activity

Reset, Abort current connections and estabilish new connections and settings.

kunall17 · 2016-08-23T04:16:18Z

Updated the branch!

niftynei · 2016-10-19T21:13:16Z

@kunall17 this is super old, but do you have any interest in reviving this PR?

kunall17 · 2016-10-21T04:08:44Z

@niftynei yeah sure!
There would be a complexity with the widget implemented now
We'll have to show from which user are these messages from.

niftynei · 2016-10-21T17:38:33Z

@kunall17 awesome! is there a way for the widget to only be registered for messages from a single realm? for example if you log in to more than realm, you pick which realm to see messages for in the configuration activity. just an idea.

timabbott · 2016-12-15T22:48:48Z

@kunall17 what's the status of this PR? Is it still something we intend to do?

kunall17 · 2016-12-16T04:09:25Z

@timabbott yeah definitely, this is one great feature, but after migration to retrofit this PR would have to undergo a lot of changes, I'll see to update this one!

saketkumar · 2016-12-21T23:50:50Z

@kunall17 This is really a great feature. Tell me if you need any kind of help in this. I would be happy to help. :)

kunall17 · 2016-12-27T18:47:48Z

@saketkumar95 sure if you want to revive this PR, you can use the commits in this PR!
Just make sure you will have to edit the widget as well!

yadav-rahul · 2017-01-29T15:03:07Z

@kunall17 Can I test this PR?

kunall17 · 2017-01-30T10:27:59Z

@yadav-rahul

Can I test this PR?

Testing?
This works as expected but this one is very old, and will have to be worked intensively to be revived again!
If you want you can definitely use the the commits and fix the merge conflicts and post as PR!

zulipbot · 2017-05-22T21:43:41Z

Heads up @kunall17, we just merged some commits (latest: 471dca2) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

kunall17 force-pushed the patch-4 branch from 67e47f9 to 1ed4fd2 Compare April 18, 2016 06:46

kunall17 force-pushed the patch-4 branch from d106288 to 773138b Compare June 27, 2016 18:44

kunall17 force-pushed the patch-4 branch from 773138b to 4b4de40 Compare August 6, 2016 21:26

niftynei reviewed Aug 12, 2016
View reviewed changes

kunall17 force-pushed the patch-4 branch from 4b4de40 to da88bfc Compare August 15, 2016 06:34

kunall17 force-pushed the patch-4 branch from da88bfc to 58ec138 Compare August 16, 2016 20:02

kunall17 force-pushed the patch-4 branch from 58ec138 to cb7e943 Compare August 17, 2016 03:31

niftynei reviewed Aug 22, 2016
View reviewed changes

kunall17 added 2 commits August 23, 2016 09:12

Add Realm item to ZulipActivity Menu

0e5ebec

Added SharedPreferences to store the realms

72da75c

This GlobalSettings will store all the info about the saved realms.

kunall17 added 16 commits August 23, 2016 09:12

Method to create a new Realm

2cb7684

Changes the database helper and save default settings for the server.

Method to switch the current realm

119848c

Saves current server position, changes the databaseHelper and get's the saved data for this server

Added a DialogFragment for the list of Realms

2c0bd80

Switch realm on listView item click

cafa69e

Switch realm method in ZulipActivity

10ce13d

Abort current connections, handlers and establish new ones.

Added server Url, realmName editText to the login Activity

c7e510d

Save realmName, serverUrl in asynLogin

eb244f7

Pass Server URL to HTTPRequest for logging in.

7dba755

Save apikey, server to sharedPreferences while login

da6713b

Add new realm button code to realmDialog

362808e

Change Title in LoginActivity if started from add realm

6e4d804

Login through add realm in AsyncLogin

194a581

Finish DevAuthActivity first then finish LoginActivity to login to Zu…

d002428

…lip Activity

Save settings for the new realm settings.

034af89

Reset, Abort current connections and estabilish new connections and settings.

Changed database name according to realm Position

e9b3926

Dismiss dialog after signing in Dev Auth Backend

f21827d

kunall17 force-pushed the patch-4 branch from cb7e943 to f21827d Compare August 23, 2016 04:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch/Add servers without logging in/out #51

Switch/Add servers without logging in/out #51

kunall17 commented Apr 17, 2016 •

edited

Loading

smarx commented Apr 17, 2016

ryansnowboarder commented Apr 19, 2016

kunall17 commented Apr 20, 2016 •

edited

Loading

ryansnowboarder commented Apr 20, 2016

niftynei commented May 10, 2016

kunall17 commented Jun 27, 2016

niftynei commented Jul 19, 2016

niftynei Aug 12, 2016 •

edited

Loading

kunall17 Aug 17, 2016

niftynei commented Aug 12, 2016

niftynei commented Aug 16, 2016

kunall17 commented Aug 16, 2016

niftynei commented Aug 16, 2016 •

edited

Loading

kunall17 commented Aug 17, 2016 •

edited

Loading

niftynei Aug 22, 2016

kunall17 commented Aug 23, 2016

niftynei commented Oct 19, 2016

kunall17 commented Oct 21, 2016

niftynei commented Oct 21, 2016

timabbott commented Dec 15, 2016

kunall17 commented Dec 16, 2016

saketkumar commented Dec 21, 2016

kunall17 commented Dec 27, 2016

yadav-rahul commented Jan 29, 2017

kunall17 commented Jan 30, 2017

zulipbot commented May 22, 2017

Switch/Add servers without logging in/out #51

Are you sure you want to change the base?

Switch/Add servers without logging in/out #51

Conversation

kunall17 commented Apr 17, 2016 • edited Loading

smarx commented Apr 17, 2016

ryansnowboarder commented Apr 19, 2016

kunall17 commented Apr 20, 2016 • edited Loading

ryansnowboarder commented Apr 20, 2016

niftynei commented May 10, 2016

kunall17 commented Jun 27, 2016

niftynei commented Jul 19, 2016

niftynei Aug 12, 2016 • edited Loading

Choose a reason for hiding this comment

kunall17 Aug 17, 2016

Choose a reason for hiding this comment

niftynei commented Aug 12, 2016

niftynei commented Aug 16, 2016

kunall17 commented Aug 16, 2016

niftynei commented Aug 16, 2016 • edited Loading

kunall17 commented Aug 17, 2016 • edited Loading

niftynei Aug 22, 2016

Choose a reason for hiding this comment

kunall17 commented Aug 23, 2016

niftynei commented Oct 19, 2016

kunall17 commented Oct 21, 2016

niftynei commented Oct 21, 2016

timabbott commented Dec 15, 2016

kunall17 commented Dec 16, 2016

saketkumar commented Dec 21, 2016

kunall17 commented Dec 27, 2016

yadav-rahul commented Jan 29, 2017

kunall17 commented Jan 30, 2017

zulipbot commented May 22, 2017

kunall17 commented Apr 17, 2016 •

edited

Loading

kunall17 commented Apr 20, 2016 •

edited

Loading

niftynei Aug 12, 2016 •

edited

Loading

niftynei commented Aug 16, 2016 •

edited

Loading

kunall17 commented Aug 17, 2016 •

edited

Loading