-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dsnparse #298
base: main
Are you sure you want to change the base?
Update dsnparse #298
Conversation
Did this work? Sorry I got a bunch of emails and checking back on this |
Seems all of the tests failed lol. I'll take a look may be a problem with the action. |
First time I'm working with a poetry type project and I guess I messed up. I really tried to limit the change. I can try again tomorrow to see what I did wrong, but if you get to the issue or fix it please respond in here. I want to know how for the future |
no big deal @Siliconrob just run |
Thanks for the tip. Poetry is kind of nice and more ordered than pip. I'm writing up a FastAPI using it and now I see how it works. |
I did what you said @zschumacher . Is this better? |
Running the tests now |
Ok got to dig into the test results to find what went wrong 🤔. Thanks |
#297
Not sure if this is enough. I ran the tests and they are consistent between the changes, but if this needs further work send it back over to me.
@zschumacher