Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dsnparse #298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update dsnparse #298

wants to merge 2 commits into from

Conversation

Siliconrob
Copy link

@Siliconrob Siliconrob commented Aug 6, 2024

#297

Not sure if this is enough. I ran the tests and they are consistent between the changes, but if this needs further work send it back over to me.

@zschumacher

@Siliconrob
Copy link
Author

Did this work? Sorry I got a bunch of emails and checking back on this

@zschumacher
Copy link
Owner

Did this work? Sorry I got a bunch of emails and checking back on this

Seems all of the tests failed lol. I'll take a look may be a problem with the action.

@Siliconrob
Copy link
Author

First time I'm working with a poetry type project and I guess I messed up. I really tried to limit the change. I can try again tomorrow to see what I did wrong, but if you get to the issue or fix it please respond in here. I want to know how for the future

@zschumacher
Copy link
Owner

First time I'm working with a poetry type project and I guess I messed up. I really tried to limit the change. I can try again tomorrow to see what I did wrong, but if you get to the issue or fix it please respond in here. I want to know how for the future

no big deal @Siliconrob just run poetry lock --no-update

@Siliconrob
Copy link
Author

Thanks for the tip. Poetry is kind of nice and more ordered than pip. I'm writing up a FastAPI using it and now I see how it works.
For this though I can get back to this on the weekend if you are waiting on me.

@Siliconrob
Copy link
Author

I did what you said @zschumacher . Is this better?

@zschumacher
Copy link
Owner

Running the tests now

@Siliconrob
Copy link
Author

Ok got to dig into the test results to find what went wrong 🤔. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants