Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Review Page Tests #264

Open
wants to merge 8 commits into
base: v2.x/staging
Choose a base branch
from
Open

Added Review Page Tests #264

wants to merge 8 commits into from

Conversation

sagar-1310
Copy link
Contributor

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets a "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Signed-off-by: sagar-1310 <[email protected]>
@sagar-1310 sagar-1310 mentioned this pull request Oct 24, 2024
14 tasks
expect(title).toBe(INSTALLATION_PAGE_TITLE);
})

test('Test View Yaml Button', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test to ensure that editing the YAML is not permitted on the Review tab.

expect(reviewPage.launchConfigTabPendingIcon).toBeTruthy()
})

test('Test Finish Installation and Test Previous step', async ({ page }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a test to verify that the 'Finish Installation' button becomes enabled once all statuses display a green checkmark. Additionally, we could test the outcome when clicking the 'Finish Installation' button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merge Ready
Development

Successfully merging this pull request may close these issues.

3 participants