-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Review Page Tests #264
base: v2.x/staging
Are you sure you want to change the base?
Conversation
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
expect(title).toBe(INSTALLATION_PAGE_TITLE); | ||
}) | ||
|
||
test('Test View Yaml Button', async ({ page }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test to ensure that editing the YAML is not permitted on the Review tab.
expect(reviewPage.launchConfigTabPendingIcon).toBeTruthy() | ||
}) | ||
|
||
test('Test Finish Installation and Test Previous step', async ({ page }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a test to verify that the 'Finish Installation' button becomes enabled once all statuses display a green checkmark. Additionally, we could test the outcome when clicking the 'Finish Installation' button.
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
Proposed changes
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments