Major Refactor

[timgerstel]

1. Make sure yaml and schema are ALWAYS set
2. Change the description of smpe on the "Installation Type" stage as per @struga0258 's suggestion
3. Wrap all global variables in components in useState() to reduce memory cost *Edit: this is still here but it was actually useless lol
4. Fix scrolling on most stages
5. Fix Initialization stage status not updating when all substeps are complete
6. Add popup messages for upload yaml button on Launch Config/Networking stages
7. Make editor use entire Zowe schema
8. Use more Constants.tsx
9. Add ability to retrieve example-zowe.yaml and JSON schemas when using SMPE mode
10. Remove duplicate and unused vars
11. Fix cursor jumping to end of port input on networking stage
12. "Skip" on Unpax stage now fetches example-zowe.yaml and schemas
13. Integrate @skurnevich's method of downloading example-zowe.yaml and schemas instead of parsing cat commands🐈
14. Fix upload not working
15. Fix improper merging of example-zowe.yaml and current config thanks to @skurnevich deep merge method
16. Remove unused imports
17. Reduce duplication
18. Remove unused or unnecessary function args
19. Fix schema errors
20. Fix difference between smpe install dir and download/upload. Download/upload will no longer unpax to /runtime
21. Fix makeDir infinite loop on planning stage with invalid dirs
22. Fix yaml encoding so that zwe start can be run
23. Make editor wider
24. Fix certificates stage resetting zowe.setup.certificate values when changing zowe.verifyCertificates
25. Increase editor width and height
26. Probably more i forgot

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Change in a documentation
• Refactor the code
• Chore, repository cleanup, updates the dependencies.
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

• If the changes in this PR are meant for the next release / mainline, this PR targets a "staging" branch.
• My code follows the style guidelines of this project (see: Contributing guideline)
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• New and existing unit tests pass locally with my changes
• video or image is included if visual changes are made

• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

[skurnevich]

Does not work for me:

Local pax file uploading fails

While downloading pax fails on schema parsing

14:43:42.429 › error setting schema from pax: SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)

For the last one i have created the PR 179 to replace cat command output parsing with files downloading.
You can merge it first, or incorporate changes into this PR. The factual change is smaller than it looks, you just need to replace readExampleYamlAndSchema function and remove parseExampleYamlFromPax blocks as downloaded yaml and json files are ready to use

[skurnevich]

Hi @timgerstel is this PR ready for review/merge or would you like to add more changes?

[DivergentEuropeans]

Created PR: #194

[DivergentEuropeans]

shouldn't this be called "getExampleYamlAndSchemas"

I only see this used in 2 places, 1 in Stepper which is conditional to not SMPE and 2 in
Unpax step which is also not SMPE

[DivergentEuropeans]

lastActiveState is already a flat object with no nested properties, at a quick glance, don't see it set anywhere. Is this essential?

[DivergentEuropeans]

Makes sense 👍

[DivergentEuropeans]

Home.tsx change is v satisfying

[DivergentEuropeans]

N i c e

[DivergentEuropeans]

that all that adjv stuff worked

[DivergentEuropeans]

I haven't tested it, but I think @timgerstel might be right here. Not that you're wrong @skurnevich , I think both things are true: using const with useState introduces a small overhead. So it would be like:
For constants and simple values that do not involve expensive computation, use them directly without useState.
For values that involve expensive computation or need to persist across renders, use useState.

So something like this might be max/minning:

const Certificates = () => {
  const theme = useState(createTheme())[0]; // Expensive
  const stageLabel = 'Initialization';
  const STAGE_ID = useState(getStageDetails(INIT_STAGE_LABEL).id)[0]; // Potentially expensive?
};

[DivergentEuropeans]

So if BASE_SCHEMA is AJV "fixed", can't we remove the schemas in Networking + Launch Config and use BASE_SCHEMA? Or lmk I might be missing something

[DivergentEuropeans]

This whole chunk is difficult to rea dfor me, but it looks mostly like a "code move" so it seems alright

[DivergentEuropeans]

If this was tested, then you want to add:
alertEmitter.emit('showAlert', 'Please view Job Output for more details', 'error');

[DivergentEuropeans]

I don't think this is a good addition. I remember cases where res.status = 0, yet the command failed. That was the whole point of using 'JCL_UNIX_SCRIPT_OK' as a better source of truth over status

[DivergentEuropeans]

Same point here about unreliability of res.status