Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @biomejs/biome to v1.8.2 #552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 25, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@biomejs/biome (source) 1.8.1 -> 1.8.2 age adoption passing confidence

Release Notes

biomejs/biome (@​biomejs/biome)

v1.8.2

Compare Source

CLI
Bug fixes
  • Fix #​3201 by correctly injecting the source code of the file when printing the diagnostics. Contributed by @​ematipico
  • Fix #​3179 where comma separators are not correctly removed after running biome migrate and thus choke the parser. Contributed by @​Sec-ant
  • Fix #​3232 by correctly using the colors set by the user. Contributed by @​ematipico
Enhancement
  • Reword the reporter message No fixes needed to No fixes applied.

    The former message is misleading when there're still errors or warnings in the files that should be taken care of manually. For example:

    Checked 2 files in <TIME>. No fixes needed.
    Found 2 errors.
    

    The new message suits better in these cases.

    Contributed by @​Sec-ant

Configuration
Bug fixes
  • Don't conceal previous overrides (#​3176).

    Previously, each override inherited the unset configuration of the base configuration.
    This means that setting a configuration in an override can be concealed by a subsequent override that inherits of the value from the base configuration.

    For example, in the next example, noDebugger was disabled for the index.js file.

    {
      "linter": {
        "rules": {
          "suspicious": { "noDebugger": "off" }
        }
      },
      "overrides": [
        {
          "include": ["index.js"],
          "linter": {
            "rules": {
              "suspicious": { "noDebugger": "warn" }
            }
          }
        }, {
          "include": ["index.js"],
          "linter": {
            "rules": {
              "suspicious": { "noDoubleEquals": "off" }
            }
          }
        }
      ]
    }

    The rule is now correctly enabled for the index.js file.

    Contributed by @​Conaclos

Formatter
Bug fixes
JavaScript APIs
Bug fixes
  • Fix a regression introduced by the release of v1.8.0
Linter
New features
Bug fixes
  • Add nursery/noShorthandPropertyOverrides. #​2958 Contributed by @​neokidev

  • Fix [#​3084] false positive by correctly recognize parenthesized return statement. Contributed by @​unvalley

  • useImportExtensions now suggests a correct fix for import '.' and import './.'. Contributed by @​minht11

  • Fix useDateNow false positive when new Date object has arguments new Date(0).getTime(). Contributed by @​minht11.

  • The noUnmatchableAnbSelector rule is now able to catch unmatchable an+b selectors like 0n+0 or -0n+0. Contributed by @​Sec-ant.

  • The useHookAtTopLevel rule now recognizes properties named as hooks like foo.useFoo(). Contributed by @​ksnyder9801

  • Fix #​3092, prevent warning for Custom properties (--*). Contributed by @​chansuke

  • Fix a false positive in the useLiteralKeys rule. (#​3160)

    This rule now ignores the following kind of computed member name:

    const a = {
      [`line1
      line2`]: true,
    };

    Contributed by @​Sec-ant

  • The noUnknownProperty rule now ignores the composes property often used in css modules. #​3000 Contributed by @​chansuke

  • Fix false positives of the useExhaustiveDependencies rule.

    The component itself is considered stable when it is used recursively inside a hook closure defined inside of it:

    import { useMemo } from "react";
    
    function MyRecursiveComponent() {
      // MyRecursiveComponent is stable, we don't need to add it to the dependencies list.
      const children = useMemo(() => <MyRecursiveComponent />, []);
      return <div>{children}</div>;
    }

    Also, export default function and export default class are considered stable now because they can only appear at the top level of a module.

    Contributed by @​Sec-ant

  • Fix missing withDefaults macro in vue files for globals variables. Contributed by @​Shyam-Chen

Parser
Bug fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/biomejs-biome-1.x branch from c23b57e to d9c5b06 Compare June 27, 2024 18:19
@zoriya
Copy link
Owner

zoriya commented Jun 27, 2024

@onedr0p Do you think this would be possible to also update the bione version on front/package.json with this PR (and run it). This would make Biome update PR more interesting than the one char change from the config file.

If this is not possible should we simply disable those PR and use the cli to update this version?

@onedr0p
Copy link
Contributor

onedr0p commented Jun 27, 2024

Sure we might have to revisit ignoring all frontend updates since it's a flat ignore of the entire folder.

@onedr0p
Copy link
Contributor

onedr0p commented Jun 27, 2024

What does the manual (CLI) process entail? We can update the ignorePaths in the config like so

"ignorePaths": [
  "**/front/.yarn/**",
  "**/front/apps/**",
  "**/front/packages/**",
],

This way the front/packages.json will get picked up by renovate but unsure what you expect and I am not sure if renovate can cover the CLI commands that need to be ran.

@zoriya
Copy link
Owner

zoriya commented Jun 28, 2024

Updating the frontend means:

  • Updating everything under front/package.json (and running biome for coding style changes)
  • Updating every other package
  • Running expo install so it prevents the use of newer versions not yet supported
  • Pin those versions to other packages needing this (to prevent package duplication)
  • Run on every platform to be sure everything will work
  • Merge

I think some of those steps will always need to be done by hand but maybe renovate could help a bit.

It might be good to look at how solito does this since they prone mono-repo with both mobile and web.

@onedr0p
Copy link
Contributor

onedr0p commented Jun 28, 2024

It seems maybe possible using this type of config in renovate?

https://docs.renovatebot.com/configuration-options/#postupgradetasks

@renovate renovate bot force-pushed the renovate/biomejs-biome-1.x branch from d9c5b06 to d20ca03 Compare June 28, 2024 13:57
@zoriya
Copy link
Owner

zoriya commented Jun 28, 2024

Thats look like what we want but it can only be used on self hosted renovate. Should we give up and keep the current approach?

@onedr0p
Copy link
Contributor

onedr0p commented Jun 28, 2024

Probably the latter, seems like you can just remove the custom manager for biome in the renovate config?

@renovate renovate bot force-pushed the renovate/biomejs-biome-1.x branch from d20ca03 to 2361ee1 Compare June 30, 2024 09:03
@renovate renovate bot force-pushed the renovate/biomejs-biome-1.x branch from 2361ee1 to cc0079b Compare June 30, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants