Switch to fmp4 intead of mgepg #542
Draft
+29
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoriya
commented
Jun 17, 2024
| @@ -119,8 +119,8 @@ func toSegmentStr(segments []float64) string { | |||
| func (ts *Stream) run(start int32) error { | |||
| // Start the transcode up to the 100th segment (or less) | |||
| length, is_done := ts.file.Keyframes.Length() | |||
| end := min(start+100, length) | |||
There was a problem hiding this comment.
Remember to revert this after testing
|
Maybe it would be wisest to switch to |
|
I'm realising supporting this would allow av1 streaming. This would be huge to reduce bandwidth usage. Definitely want to work on this on the following days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #534
Refs:
Currently, this PR is not working, I guess timestamps or mp4 headers are invalid /shrug