Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: justify bookmarks #412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daiyam
Copy link

@daiyam daiyam commented Apr 23, 2023

This PR adds the feature to justify the bookmarks on the center or on the right.

@zombieFox
Copy link
Owner

I've explored using flex in place of grid to align the bookmark tiles. This causes the width of the tiles to not respect the defined width.

Also there is unexpected behaviour when the bookmark count exceeds the group width:

Kapture.2023-06-18.at.17.20.55.mp4

I do not think using flex for the bookmark group is suitable for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants