Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): add setting to enable durable locks on crdb #7982

Merged
merged 8 commits into from
May 27, 2024

Conversation

adlerhurst
Copy link
Member

Which Problems Are Solved

There were rare cases where Cockroachdb got blocked during runtime of ZITADEL and returned WRITE_TOO_OLD-errors to ZITADEL.

How the Problems Are Solved

The root cause of the problem is described in this github issue of the database. The workaround provided by the database is enabling the enable_durable_locking_for_serializable-flag as described here.

Additional Changes

  • Added additional command to zitadel init called settings to allow making changes using the admin user.
  • zitadel init ensures that variables are set.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 8:43am

Copy link

github-actions bot commented May 17, 2024

Thanks for your contribution! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

@adlerhurst adlerhurst changed the title feat(init): add setting to enable durable locks on crdb fix(init): add setting to enable durable locks on crdb May 17, 2024
@adlerhurst adlerhurst enabled auto-merge (squash) May 17, 2024 14:37
@hifabienne hifabienne requested a review from muhlemmer May 21, 2024 09:31
muhlemmer
muhlemmer previously approved these changes May 21, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@0b366be). Learn more about missing BASE report.

Files Patch % Lines
cmd/initialise/verify_settings.go 66.66% 5 Missing and 2 partials ⚠️
cmd/initialise/init.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7982   +/-   ##
=======================================
  Coverage        ?   62.09%           
=======================================
  Files           ?     1387           
  Lines           ?   111806           
  Branches        ?        0           
=======================================
  Hits            ?    69430           
  Misses          ?    38482           
  Partials        ?     3894           
Flag Coverage Δ
core-integration-tests-postgres 62.09% <61.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adlerhurst adlerhurst merged commit cff0f73 into main May 27, 2024
27 checks passed
@adlerhurst adlerhurst deleted the verify-settings branch May 27, 2024 09:03
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants