inherit FiberRef's when a failed fiber joins #8731
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with a problem similar to #8721
Fiber#join
doesn't inherit FiberRef values if the fiber was failed.For example:
prints just
bar
, butprints
foo, bar
.I expected these snippets to work the same way.
The same expectation is about
ZIO#disconnected
:Now this discards
FiberRef
updates bacause uses.join
under the hood.If this behavior must be corrected, I will be glad if my PR is approved