Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zio-test: classic assertion equalTo using Diff #8664

Open
Fristi opened this issue Feb 8, 2024 · 13 comments · May be fixed by #8808
Open

zio-test: classic assertion equalTo using Diff #8664

Fristi opened this issue Feb 8, 2024 · 13 comments · May be fixed by #8808

Comments

@Fristi
Copy link
Contributor

Fristi commented Feb 8, 2024

At the moment the equalTo of smart assertions uses the Diff mechanism, however the classic assertion does not

Also, the rendering of the Diff seems to happen in the assertion, is that something we would like ?

@jdegoes
Copy link
Member

jdegoes commented Mar 7, 2024

/bounty $75

The rendering should happen outside, probably, so we can have a more modular architecture that permits code reuse and swapping in alternate renderings.

Copy link

algora-pbc bot commented Mar 7, 2024

💎 $75 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #8664 with your implementation plan
  2. Submit work: Create a pull request including /claim #8664 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟡 @kaf-lamed-beyt Mar 17, 2024, 2:40:56 PM #8695
🟢 @varshith257 May 1, 2024, 8:39:23 AM #8808

@kaf-lamed-beyt
Copy link

kaf-lamed-beyt commented Mar 17, 2024

Hi @jdegoes, I'd love to attempt this. Can you assign me?

/attempt #8664

Algora profile Completed bounties Tech Active attempts Options
@kaf-lamed-beyt 7 bounties from 3 projects
JavaScript, HTML,
TypeScript & more
Cancel attempt

@jdegoes
Copy link
Member

jdegoes commented Mar 19, 2024

No need to assign, just follow the instructions of the @algora-pbc bot!

@kaf-lamed-beyt
Copy link

Sounds good.

Copy link

algora-pbc bot commented Mar 24, 2024

@kaf-lamed-beyt: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Mar 26, 2024

💡 @kaf-lamed-beyt submitted a pull request that claims the bounty. You can visit your bounty board to reward.

varshith257 added a commit to varshith257/zio that referenced this issue May 1, 2024
Copy link

algora-pbc bot commented May 1, 2024

@varshith257: We appreciate your enthusiasm but since you already have 3 active bounty attempts, we're going to keep this open for other contributors to attempt. 🫡

@varshith257
Copy link

/attempt #8664

Copy link

algora-pbc bot commented May 1, 2024

@varshith257: We appreciate your enthusiasm but since you already have 3 active bounty attempts, we're going to keep this open for other contributors to attempt. 🫡

@varshith257
Copy link

varshith257 commented May 1, 2024

/attempt #8664

Copy link

algora-pbc bot commented May 1, 2024

Note

The user @kaf-lamed-beyt is already attempting to complete issue #8664 and claim the bounty. We recommend checking in on @kaf-lamed-beyt's progress, and potentially collaborating, before starting a new solution.

@varshith257 varshith257 linked a pull request May 1, 2024 that will close this issue
Copy link

algora-pbc bot commented May 1, 2024

💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants