remove newly added methods, change signature of asScala to return fin…

…ite duration instead

core-tests/shared/src/test/scala/zio/DurationSpec.scala

@@ -1,12 +1,12 @@
 package zio
 
-import zio.test.Assertion.{equalTo, not, throwsA}
+import zio.test.Assertion.{equalTo, not}
 import zio.test.assert
 
 import java.time.temporal.ChronoUnit
 import java.time.{Duration => JavaDuration}
 import java.util.concurrent.TimeUnit
-import scala.concurrent.duration.{Duration => ScalaDuration}
+import scala.concurrent.duration.{Duration => ScalaDuration, FiniteDuration => ScalaFiniteDuration}
 
 object DurationSpec extends ZIOBaseSpec {
 
@@ -155,13 +155,7 @@ object DurationSpec extends ZIOBaseSpec {
  assert(Duration.Infinity.isZero)(equalTo(false))
  },
  test("It converts into the infinite s.c.d.Duration") {
- assert(Duration.Infinity.asScala)(equalTo(ScalaDuration.Inf: ScalaDuration))
- },
- test("It converts into None for asFiniteDuration") {
- assert(Duration.Infinity.asFiniteDuration)(equalTo(None))
- },
- test("It throws an exception for asFiniteDurationUnsafe") {
- assert(Duration.Infinity.asFiniteDurationUnsafe)(throwsA[IllegalArgumentException])
+ assert(Duration.Infinity.asScala)(equalTo(ScalaFiniteDuration.apply(Long.MaxValue, TimeUnit.NANOSECONDS)))
  },
  test("It converts into a Long.MaxValue second-long JDK Duration") {
  assert(Duration.Infinity)(equalTo(JavaDuration.ofNanos(Long.MaxValue)))

core/shared/src/main/scala/zio/Duration.scala

@@ -173,21 +173,7 @@ final class DurationOps(private val duration: Duration) extends AnyVal {
  }
  }
 
- def asScala: ScalaDuration = duration match {
- case Duration.Infinity => ScalaDuration.Inf
- case Duration.Zero => ScalaDuration.Zero
- case _ => ScalaFiniteDuration(duration.toNanos, TimeUnit.NANOSECONDS)
- }
-
- def asFiniteDuration: Option[ScalaFiniteDuration] = duration match {
- case Duration.Infinity => None
- case Duration.Zero => Some(ScalaDuration.Zero)
- case _ => Some(ScalaFiniteDuration(duration.toNanos, TimeUnit.NANOSECONDS))
- }
-
- def asFiniteDurationUnsafe: ScalaFiniteDuration = duration match {
- case Duration.Infinity =>
- throw new IllegalArgumentException("Duration is infinite but finite duration was expected")
+ def asScala: ScalaFiniteDuration = duration match {
  case Duration.Zero => ScalaDuration.Zero
  case _ => ScalaFiniteDuration(duration.toNanos, TimeUnit.NANOSECONDS)
  }