-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful shutdown of a stream for a single subscription #1201
base: master
Are you sure you want to change the base?
Commits on Apr 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a9a6f8 - Browse repository at this point
Copy the full SHA 7a9a6f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8196b3 - Browse repository at this point
Copy the full SHA c8196b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 583d112 - Browse repository at this point
Copy the full SHA 583d112View commit details -
Configuration menu - View commit details
-
Copy full SHA for f55c898 - Browse repository at this point
Copy the full SHA f55c898View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f86958 - Browse repository at this point
Copy the full SHA 6f86958View commit details -
Alternative interface, workaround inability to deconstruct tuples in …
…for comprehension
Configuration menu - View commit details
-
Copy full SHA for 9eb989b - Browse repository at this point
Copy the full SHA 9eb989bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a32c74 - Browse repository at this point
Copy the full SHA 9a32c74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98df970 - Browse repository at this point
Copy the full SHA 98df970View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29f8e44 - Browse repository at this point
Copy the full SHA 29f8e44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1215c43 - Browse repository at this point
Copy the full SHA 1215c43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97d7e6f - Browse repository at this point
Copy the full SHA 97d7e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 336aa8d - Browse repository at this point
Copy the full SHA 336aa8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 361cfec - Browse repository at this point
Copy the full SHA 361cfecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ee9696 - Browse repository at this point
Copy the full SHA 4ee9696View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfa0afa - Browse repository at this point
Copy the full SHA dfa0afaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15ec438 - Browse repository at this point
Copy the full SHA 15ec438View commit details -
Configuration menu - View commit details
-
Copy full SHA for 885d9c9 - Browse repository at this point
Copy the full SHA 885d9c9View commit details -
Pause a partition when its stream is ended
During a graceful shutdown the partition stream is ended. The runloop however, is still happily fetching records for that stream. These are then put in the stream's queue even though they will never be read. This is taking away network and CPU at a moment where the application should focus on doing a clean shutdown quickly. It could even cause an OOM for application that are tuned for the case where processing happens almost immediately. With this change, when a stream is ended: - the partition is paused, - already fetched new records are not added to the stream's queue. Also: less logging at start of a poll.
Configuration menu - View commit details
-
Copy full SHA for 1408148 - Browse repository at this point
Copy the full SHA 1408148View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed326a2 - Browse repository at this point
Copy the full SHA ed326a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 252cc3a - Browse repository at this point
Copy the full SHA 252cc3aView commit details -
Fix race condition between join and timeout, leading to unwanted inte…
…rruption of withStream
Configuration menu - View commit details
-
Copy full SHA for 9954dda - Browse repository at this point
Copy the full SHA 9954ddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for add21e9 - Browse repository at this point
Copy the full SHA add21e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec18c0 - Browse repository at this point
Copy the full SHA 8ec18c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c409368 - Browse repository at this point
Copy the full SHA c409368View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dbddfc - Browse repository at this point
Copy the full SHA 2dbddfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7838929 - Browse repository at this point
Copy the full SHA 7838929View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9e48ab - Browse repository at this point
Copy the full SHA c9e48abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d334e0 - Browse repository at this point
Copy the full SHA 5d334e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60464b6 - Browse repository at this point
Copy the full SHA 60464b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 258168d - Browse repository at this point
Copy the full SHA 258168dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e25cd4 - Browse repository at this point
Copy the full SHA 6e25cd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d19e16 - Browse repository at this point
Copy the full SHA 8d19e16View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1edcab - Browse repository at this point
Copy the full SHA f1edcabView commit details
Commits on May 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f19417b - Browse repository at this point
Copy the full SHA f19417bView commit details
Commits on May 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5365aa0 - Browse repository at this point
Copy the full SHA 5365aa0View commit details
Commits on May 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f977001 - Browse repository at this point
Copy the full SHA f977001View commit details
Commits on May 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c54b3e9 - Browse repository at this point
Copy the full SHA c54b3e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a6d82 - Browse repository at this point
Copy the full SHA 33a6d82View commit details -
Configuration menu - View commit details
-
Copy full SHA for a155267 - Browse repository at this point
Copy the full SHA a155267View commit details
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15e041f - Browse repository at this point
Copy the full SHA 15e041fView commit details
Commits on Jun 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c21f82 - Browse repository at this point
Copy the full SHA 7c21f82View commit details
Commits on Jul 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f5e42c5 - Browse repository at this point
Copy the full SHA f5e42c5View commit details
Commits on Aug 10, 2024
-
Small improvements to the Producer (#1272)
By using ZIO.async, we no longer need a reference to the zio runtime, nor do we need the `exec` trickery anymore.
Configuration menu - View commit details
-
Copy full SHA for 9a31569 - Browse repository at this point
Copy the full SHA 9a31569View commit details -
Document metrics and consumer tuning based on metrics (#1280)
Also: fix typo and make metric descriptions consistent.
Configuration menu - View commit details
-
Copy full SHA for 27f033e - Browse repository at this point
Copy the full SHA 27f033eView commit details -
Add alternative fetch strategy for many partitions (#1281)
When many hundreds of partitions need to be consumed, an excessive amount of heap can be used for pre-fetching. The `ManyPartitionsQueueSizeBasedFetchStrategy` works similarly as the default `QueueSizeBasedFetchStrategy` but limits total memory usage.
Configuration menu - View commit details
-
Copy full SHA for 108b285 - Browse repository at this point
Copy the full SHA 108b285View commit details -
Alternative producer implementation (#1285)
Refactoring of the producer so that it handles errors per record.
Configuration menu - View commit details
-
Copy full SHA for eaae8af - Browse repository at this point
Copy the full SHA eaae8afView commit details -
Prevent users from enabling auto commit (#1290)
Zio-kafka applications always pre-fetch data so that user streams can process the data asynchronously. This is not compatible with auto commit. When auto commit is enabled, the consumer will automatically commit batches _before_ they are processed by the user streams. An unaware user might accidentally enable auto commit and lose data during rebalances. Solves #1289.
Configuration menu - View commit details
-
Copy full SHA for c862686 - Browse repository at this point
Copy the full SHA c862686View commit details -
Update scalafmt-core to 3.8.3 (#1291)
## About this PR 📦 Updates [org.scalameta:scalafmt-core](https://github.com/scalameta/scalafmt) from `3.8.2` to `3.8.3` 📜 [GitHub Release Notes](https://github.com/scalameta/scalafmt/releases/tag/v3.8.3) - [Version Diff](scalameta/scalafmt@v3.8.2...v3.8.3) ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below. Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/767fcfecbfd53c507152f6cf15c846176bae561d/docs/repo-specific-configuration.md) file. _Have a fantastic day writing Scala!_ <details> <summary>⚙ Adjust future updates</summary> Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" } }] ``` </details> <sup> labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1 </sup> Co-authored-by: zio-scala-steward[bot] <145262613+zio-scala-steward[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ff4ea7f - Browse repository at this point
Copy the full SHA ff4ea7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbbfe48 - Browse repository at this point
Copy the full SHA bbbfe48View commit details -
Configuration menu - View commit details
-
Copy full SHA for a75a78e - Browse repository at this point
Copy the full SHA a75a78eView commit details
Commits on Oct 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5fec195 - Browse repository at this point
Copy the full SHA 5fec195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 699e6e8 - Browse repository at this point
Copy the full SHA 699e6e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aafd4ec - Browse repository at this point
Copy the full SHA aafd4ecView commit details
Commits on Oct 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 34f5110 - Browse repository at this point
Copy the full SHA 34f5110View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f9bef - Browse repository at this point
Copy the full SHA 95f9befView commit details
Commits on Nov 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f33dc34 - Browse repository at this point
Copy the full SHA f33dc34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cb1eee - Browse repository at this point
Copy the full SHA 3cb1eeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87eadd8 - Browse repository at this point
Copy the full SHA 87eadd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31cd086 - Browse repository at this point
Copy the full SHA 31cd086View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6d2afa - Browse repository at this point
Copy the full SHA a6d2afaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1835758 - Browse repository at this point
Copy the full SHA 1835758View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c28b89 - Browse repository at this point
Copy the full SHA 6c28b89View commit details -
Configuration menu - View commit details
-
Copy full SHA for e649753 - Browse repository at this point
Copy the full SHA e649753View commit details -
Configuration menu - View commit details
-
Copy full SHA for 348b01e - Browse repository at this point
Copy the full SHA 348b01eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9f1597 - Browse repository at this point
Copy the full SHA c9f1597View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a9b6f6 - Browse repository at this point
Copy the full SHA 4a9b6f6View commit details -
Fix rebalanceSafeCommits test timing out
After consumer 1 is shutdown (using stopConsumption), rebalances happen and partitions from consumer 2 are assigned. These streams are never started, so the finalizer completing completedPromise is never called. Waiting for these to complete takes 3 minutes (default maxRebalanceDuration). In case that streams were assigned and no record was ever put in their queues, there's no need to wait for the stream to complete.
Configuration menu - View commit details
-
Copy full SHA for 3c0cfd1 - Browse repository at this point
Copy the full SHA 3c0cfd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90ca347 - Browse repository at this point
Copy the full SHA 90ca347View commit details -
Configuration menu - View commit details
-
Copy full SHA for edb7005 - Browse repository at this point
Copy the full SHA edb7005View commit details -
Configuration menu - View commit details
-
Copy full SHA for e400012 - Browse repository at this point
Copy the full SHA e400012View commit details -
Apply suggestions from code review
Co-authored-by: Erik van Oosten <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e83bc89 - Browse repository at this point
Copy the full SHA e83bc89View commit details -
Configuration menu - View commit details
-
Copy full SHA for efd3937 - Browse repository at this point
Copy the full SHA efd3937View commit details -
Configuration menu - View commit details
-
Copy full SHA for e29d63e - Browse repository at this point
Copy the full SHA e29d63eView commit details
Commits on Nov 3, 2024
-
Update docs/consuming-kafka-topics-using-zio-streams.md
Co-authored-by: Erik van Oosten <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f19f90d - Browse repository at this point
Copy the full SHA f19f90dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c71a08f - Browse repository at this point
Copy the full SHA c71a08fView commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c27da7 - Browse repository at this point
Copy the full SHA 5c27da7View commit details -
This caused the "process outstanding commits after a graceful shutdown with aggregateAsync using `maxRebalanceDuration`" to fail.
Configuration menu - View commit details
-
Copy full SHA for 9901b16 - Browse repository at this point
Copy the full SHA 9901b16View commit details
Commits on Nov 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a9925d5 - Browse repository at this point
Copy the full SHA a9925d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dac1865 - Browse repository at this point
Copy the full SHA dac1865View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddbd576 - Browse repository at this point
Copy the full SHA ddbd576View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e461ee - Browse repository at this point
Copy the full SHA 8e461eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5848e9c - Browse repository at this point
Copy the full SHA 5848e9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 143f914 - Browse repository at this point
Copy the full SHA 143f914View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5fc7bb - Browse repository at this point
Copy the full SHA d5fc7bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6f485c - Browse repository at this point
Copy the full SHA d6f485cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ef97ef - Browse repository at this point
Copy the full SHA 5ef97efView commit details
Commits on Nov 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bec0e25 - Browse repository at this point
Copy the full SHA bec0e25View commit details