Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement codec error handling #3204

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

asr2003
Copy link
Contributor

@asr2003 asr2003 commented Nov 9, 2024

/claim #3188
Closes #3188

Are there still any changes to be done, I am happy to incorporate them

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 51.06383% with 23 lines in your changes missing coverage. Please review.

Project coverage is 61.04%. Comparing base (f164c90) to head (f75748c).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/scala/zio/http/codec/HttpContentCodec.scala 34.78% 15 Missing ⚠️
...main/scala/zio/http/codec/internal/BodyCodec.scala 65.21% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3204      +/-   ##
==========================================
- Coverage   65.09%   61.04%   -4.06%     
==========================================
  Files         161      161              
  Lines       10551    11410     +859     
  Branches     2024     2025       +1     
==========================================
+ Hits         6868     6965      +97     
- Misses       3683     4445     +762     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text/plain response body encoding silent failure
2 participants