Allow applying aspects only to handlers with Request input (#3141)
#3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
force-pushed
the
handler-aspect-path-param
branch
from
d20f96b
to
3fb7844
Compare
|
@jdegoes This is not binary compatible. In fact it would make code not compile that compiled before. But that code would be impossible to run anyway. I tried to make it possible to apply context aspects to arbitrary handlers, but from what I see, that is not possible. The only other good way I see is to deprecate the method and find a new operator. |
987Nabil
force-pushed
the
handler-aspect-path-param
branch
from
3fb7844
to
959a895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual bug was, that the handler aspect could be applied to a handler that has a input different then request. There was a construct that should have prevented it, but it did not work.
To make it easier to add aspects to a single route, I added
@@methods toRoutetoo. And a test that shows, that it works with path parametersfixes #3141
/claim #3141