Accept octet-stream as media type for multipart text fields (#2746)
#2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
force-pushed
the
accept-octed-as-text
branch
from
8c73340
to
2c2b552
Compare
jdegoes
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint defined in #2746 looks and works as expected. But during testing and debugging I realised that some tools (Postman, but also we in some internal code) default fields of multipart to
octet-stream.This we did not handle gracefully until now. For fields that have no explicit media type and expect a value that is parsable by
TextBinaryCodec(aka all default types that can be represented as a String) we will acceptapplication/octet-streamwith this PR.fixes #2746
/claim #2746