Fix: Ensure wildcard MIME types in Accept header default to non-binary

zio · Nov 9, 2024 · db4d439 · db4d439
1 parent 470143e
commit db4d439
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/zio-http/jvm/src/test/scala/zio/http/MediaTypeSpec.scala b/zio-http/jvm/src/test/scala/zio/http/MediaTypeSpec.scala
@@ -37,7 +37,7 @@ object MediaTypeSpec extends ZIOHttpSpec {
       }
     },
     test("custom mime type parsing") {
-      assertTrue(MediaType.parseCustomMediaType("custom/mime").contains(MediaType("custom", "mime")))
+      assertTrue(MediaType.parseCustomMediaType("custom/mime").contains(MediaType("custom", "mime", binary = true)))
     },
     test("optional parameter parsing") {
       assertTrue(

diff --git a/zio-http/shared/src/main/scala/zio/http/MediaType.scala b/zio-http/shared/src/main/scala/zio/http/MediaType.scala
@@ -65,7 +65,8 @@ object MediaType extends MediaTypes {
     if (contentTypeParts.length == 2) {
       val subtypeParts = contentTypeParts(1).split(';')
       // Default binary to true for unknown types unless they belong to text families
-      val isBinary     = !customMediaType.startsWith("text/") &&
+      val isBinary     = customMediaType != "*/*" &&
+        !customMediaType.startsWith("text/") &&
         !customMediaType.startsWith("application/json") &&
         !customMediaType.startsWith("application/xml")
       if (subtypeParts.length >= 1) {