Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added invalidationEvents method to publish cache invalidation events. #57

Draft
wants to merge 2 commits into
base: series/1.x
Choose a base branch
from
Draft

Added invalidationEvents method to publish cache invalidation events. #57

wants to merge 2 commits into from

Conversation

ithinkicancode
Copy link
Contributor

Resolves #44

@ithinkicancode
Copy link
Contributor Author

A few notes:

  1. Recommend using the Split (side-by-side) view to review changes. Most lines are caused by indentation. Git diff is really bad at this kind of change.
  2. It's a draft because the performance of ChurnBenchmark has degraded by about 20%. It was worse in the beginning :) I have found using ZIO.when operator can degrade the performance on a hot path. I'm using regular if for now. (Might want to replace the when operator with if elsewhere too.)

@strokyl
Copy link
Contributor

strokyl commented Feb 18, 2022

A few notes:

1. Recommend using the Split (side-by-side) view to review changes. Most lines are caused by indentation. Git diff is really bad at this kind of change.

Did you try "Hide whitespace" feature in github? It help a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to add callback/hook to expiry events
2 participants
@ithinkicancode @strokyl