coverage

wip #377
zin- · Sep 7, 2024 · 6ecb40d · 6ecb40d
1 parent 63a1cf9
commit 6ecb40d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/lib/framework/repository/key_with_value_repository.dart b/lib/framework/repository/key_with_value_repository.dart
@@ -1,12 +1,11 @@
 import 'package:mem/framework/repository/key_with_value.dart';
 import 'package:mem/framework/repository/repository.dart';
 
-abstract class KeyWithValueRepositoryV2<
-    ENTITY extends KeyWithValue<KEY, dynamic>,
+abstract class KeyWithValueRepository<ENTITY extends KeyWithValue<KEY, dynamic>,
     KEY> extends Repository<ENTITY> {
-  Future<void> receive(ENTITY entity);
+  Future<void> receive(ENTITY entity) => throw UnimplementedError();
 
-  Future<void> discard(KEY key);
+  Future<void> discard(KEY key) => throw UnimplementedError();
 
-  Future<void> discardAll();
+  Future<void> discardAll() => throw UnimplementedError();
 }
diff --git a/lib/notifications/notification_repository.dart b/lib/notifications/notification_repository.dart
@@ -10,7 +10,7 @@ import 'notification/notification.dart';
 import 'flutter_local_notifications_wrapper.dart';
 
 class NotificationRepository
-    extends KeyWithValueRepositoryV2<NotificationV2, int> {
+    extends KeyWithValueRepository<NotificationV2, int> {
   final FlutterLocalNotificationsWrapper? _flutterLocalNotificationsWrapper =
       defaultTargetPlatform == TargetPlatform.android
           ? FlutterLocalNotificationsWrapper(androidDefaultIconPath)

diff --git a/lib/settings/actions.dart b/lib/settings/actions.dart
@@ -21,7 +21,9 @@ Future<void> update<Key extends PreferenceKey<Value>, Value>(
 ) =>
     v(
       () async => await (value == null
+// coverage:ignore-start
           ? _client.discard(key)
+// coverage:ignore-end
           : _client.receive(PreferenceEntity(key, value))),
       {
         'key': key,

diff --git a/lib/settings/client.dart b/lib/settings/client.dart
@@ -5,7 +5,7 @@ import 'package:mem/settings/preference_key.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 
 class PreferenceClientRepository
-    extends KeyWithValueRepositoryV2<PreferenceEntity, PreferenceKey> {
+    extends KeyWithValueRepository<PreferenceEntity, PreferenceKey> {
   Future<PreferenceEntity<T>> shipByKey<T>(PreferenceKey<T> key) => v(
         () async {
           final saved = (await SharedPreferences.getInstance()).get(key.value);
@@ -42,7 +42,4 @@ class PreferenceClientRepository
         () async => (await SharedPreferences.getInstance()).remove(key.value),
         {'key': key},
       );
-
-  @override
-  Future<void> discardAll() => throw UnimplementedError();
 }