Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Revised) Design:
Fast at indexing time (on
DocumentScope.init
), slower on lookupsBased on unicode codepoints
State stored separately from
Handle
inUri
->TrigramDat
map to allow trigram data without a long-livedHandle
Fast false-positive-possible Binary Fuse Filter check first, hashmap lookup based narrowing after
Note that lookup can be made faster at the cost of memory and indexing time by having two lookup maps in
DocumentScope
: the current one, to gather initial candidates, and a secondTrigram + Declaration
->void
map for narrowing.