Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Symbols #1876

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Workspace Symbols #1876

wants to merge 7 commits into from

Conversation

SuperAuguste
Copy link
Member

@SuperAuguste SuperAuguste commented Apr 28, 2024

(Revised) Design:

  • Fast at indexing time (on DocumentScope.init), slower on lookups

  • Based on unicode codepoints

  • State stored separately from Handle in Uri -> TrigramDat map to allow trigram data without a long-lived Handle

  • Fast false-positive-possible Binary Fuse Filter check first, hashmap lookup based narrowing after

    Note that lookup can be made faster at the cost of memory and indexing time by having two lookup maps in DocumentScope: the current one, to gather initial candidates, and a second Trigram + Declaration -> void map for narrowing.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.04%. Comparing base (93b7bbd) to head (1296105).

Current head 1296105 differs from pull request most recent head 25ccfa4

Please upload reports for the commit 25ccfa4 to get more accurate results.

Files Patch % Lines
src/TrigramStore.zig 0.00% 5 Missing ⚠️
src/DocumentStore.zig 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
+ Coverage   78.29%   80.04%   +1.75%     
==========================================
  Files          35       35              
  Lines       10687    12410    +1723     
==========================================
+ Hits         8367     9934    +1567     
- Misses       2320     2476     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuperAuguste SuperAuguste reopened this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant