Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std.Uri instead of our own code #1671

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Techatrix
Copy link
Member

std.Uri provides everything we need to deal with URIs we don't to write everything our self.
A follow-up can then remove the entire uri.zig file.

I will need to verify that this is also working on Windows.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.42%. Comparing base (d2d5f43) to head (cccfda7).

Current head cccfda7 differs from pull request most recent head d7dbd38

Please upload reports for the commit d7dbd38 to get more accurate results.

Files Patch % Lines
src/analysis.zig 0.00% 3 Missing ⚠️
src/DocumentStore.zig 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
+ Coverage   78.31%   78.42%   +0.10%     
==========================================
  Files          35       34       -1     
  Lines       10698    10575     -123     
==========================================
- Hits         8378     8293      -85     
+ Misses       2320     2282      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

`std.Uri` provides everything we need to deal with URIs we
don't to write everything our self.
A follow-up can then remove the entire uri.zig file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant