Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run: add output directory arguments #19826

Merged
merged 3 commits into from
May 9, 2024
Merged

Run: add output directory arguments #19826

merged 3 commits into from
May 9, 2024

Commits on May 5, 2024

  1. Run: add lazy path file inputs 

    This replaces `extra_file_dependencies` with support for lazy paths.

Also assert output file basenames are not empty, avoid improper use of
field default values, ensure stored strings are duplicated, and
prefer `ArrayListUnmanaged` to discourage misuse of direct field access
which wouldn't add step dependencies.
    @jacobly0
    jacobly0 committed May 5, 2024
    Configuration menu
    Copy the full SHA
    d582575 View commit details
    Browse the repository at this point in the history

  2. Build: cleanup 

     * `doc/langref` formatting
 * upgrade `.{ .path = "..." }` to `b.path("...")`
 * avoid using arguments named `self`
 * make `Build.Step.Id` usage more consistent
 * add `Build.pathResolve`
 * use `pathJoin` and `pathResolve` everywhere
 * make sure `Build.LazyPath.getPath2` returns an absolute path
    @jacobly0
    jacobly0 committed May 5, 2024
    Configuration menu
    Copy the full SHA
    e342433 View commit details
    Browse the repository at this point in the history

  3. Run: add output directory arguments 

    This allows running commands that take an output directory argument. The
main thing that was needed for this feature was generated file subpaths,
to allow access to the files in a generated directory. Additionally, a
minor change was required to so that the correct directory is created
for output directory args.
    @jacobly0
    jacobly0 committed May 5, 2024
    Configuration menu
    Copy the full SHA
    dee9f82 View commit details
    Browse the repository at this point in the history