-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included the option to call zig build run
from the project root.
#74
Open
alexjgriffith
wants to merge
3
commits into
ziglang:master
Choose a base branch
from
alexjgriffith:Add_build_run
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,6 +68,18 @@ | |
:safe #'stringp | ||
:group 'zig-mode) | ||
|
||
(defcustom zig-project-build-file "build.zig" | ||
"Name of project build file used to find the project root." | ||
:type 'string | ||
:safe #'stringp | ||
:group 'zig-mode) | ||
|
||
(defcustom zig-project-root-search-up 3 | ||
"The number of directories to search upwards to find project root." | ||
:type 'integer | ||
:group 'zig-mode | ||
:safe #'integerp) | ||
|
||
;; zig CLI commands | ||
|
||
(defun zig--run-cmd (cmd &optional source &rest args) | ||
|
@@ -123,6 +135,31 @@ If given a SOURCE, execute the CMD on it." | |
(interactive) | ||
(zig--run-cmd "run" (buffer-file-name) "-O" zig-run-optimization-mode)) | ||
|
||
(defun zig--find-project-root () | ||
"Find the directory with the `zig-project-build-file'." | ||
(let ((count 0) | ||
root-dir | ||
(dir (directory-file-name | ||
(replace-regexp-in-string "^Directory " "" default-directory)))) | ||
(while (and (< count zig-project-root-search-up) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's |
||
(let ((is-dir? (member zig-project-build-file (directory-files dir)))) | ||
(when is-dir? | ||
(setq root-dir dir)) | ||
(not is-dir?))) | ||
(setq dir (file-name-directory dir)) | ||
(setq count (+ count 1))) | ||
root-dir)) | ||
|
||
;;;###autoload | ||
(defun zig-project-build-run () | ||
"Create an executable from the current project and run it immediately." | ||
(interactive) | ||
(let ((root-dir (zig--find-project-root))) | ||
(if root-dir | ||
(let ((default-directory root-dir)) | ||
(compile (concat "zig build run"))) | ||
(message (.. "Could not find " zig-build-file))))) | ||
|
||
(defvar zig-return-to-buffer-after-format nil | ||
"Enable zig-format-buffer to return to file buffer after fmt is done.") | ||
|
||
|
@@ -519,6 +556,7 @@ This is written mainly to be used as `end-of-defun-function' for Zig." | |
(define-key map (kbd "C-c C-f") 'zig-format-buffer) | ||
(define-key map (kbd "C-c C-r") 'zig-run) | ||
(define-key map (kbd "C-c C-t") 'zig-test-buffer) | ||
(define-key map (kbd "C-c C-p") 'zig-project-build-run) | ||
map) | ||
"Keymap for Zig major mode.") | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really what I'd suggest instead of these changes is to add a (likely trivial) snippet that allows
project.el
to find the project root of Zig project. Then you can useproject-*
functions as needed inzig-project-build-run
below.