Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改plugins下的README.md,提示导入文件的方法 #2377

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

augustus0508
Copy link

Linked issue

#2376

Do what

新增了正确导入文件的写法
plugins
| -- plugin_name
| ---- init.py
| ---- plugin_name.py
| ---- hello.py

[plugin_name.py]

import plugins.plugin_name.hello (✅)
from .hello import * (✅)
import hello(❌)

@6vision
Copy link
Collaborator

6vision commented Nov 11, 2024

image
感谢pr,不过readme有写以hello插件为例,如果还使用plugin_name,可能不太容易理解了。倒是可以加一句话,注明hello即为插件的名称,需要自行替换为自己的插件名字。方便新人理解~

@augustus0508
Copy link
Author

image 感谢pr,不过readme有写以hello插件为例,如果还使用plugin_name,可能不太容易理解了。倒是可以加一句话,注明hello即为插件的名称,需要自行替换为自己的插件名字。方便新人理解~

ok已经改好了👻

@6vision
Copy link
Collaborator

6vision commented Nov 28, 2024

179行增加一句话即可,其他可以不用改动吧

@augustus0508
Copy link
Author

179行增加一句话即可,其他可以不用改动吧

加其他的是因为当时我在独立仓库中开发,对路径依赖不敏感导致合并后引发了路径依赖错误🙀。想文档里提前提醒一下避免大家到时候还要花时间排查。

@augustus0508
Copy link
Author

179行增加一句话即可,其他可以不用改动吧

但如果还感觉没必要的话我就close了😫😫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants