Skip to content

Commit

Permalink
chore(python): drop py3.7 support (apache#1981)
Browse files Browse the repository at this point in the history
## What does this PR do?

This pr drop py3.7 support

## Related issues

Closes apache#1982 

## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

## Benchmark

<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
  • Loading branch information
chaokunyang authored Dec 16, 2024
1 parent 9be8c95 commit 862667e
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.7, 3.12]
python-version: [3.8, 3.12]
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
url: https://pypi.org/project/pyfury
strategy:
matrix:
python-version: [3.7, 3.8, 3.9, 3.10.12, 3.11, 3.12]
python-version: [3.8, 3.9, 3.10.12, 3.11, 3.12]
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
Expand Down
6 changes: 1 addition & 5 deletions python/pyfury/_fury.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import enum
import logging
import os
import sys
import warnings
from dataclasses import dataclass
from typing import Dict, Tuple, TypeVar, Union, Iterable
Expand Down Expand Up @@ -80,10 +79,7 @@

from cloudpickle import Pickler

if sys.version_info[:2] < (3, 8): # pragma: no cover
from pickle5 import Unpickler
else:
from pickle import Unpickler
from pickle import Unpickler

logger = logging.getLogger(__name__)

Expand Down
5 changes: 1 addition & 4 deletions python/pyfury/_serialization.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,7 @@ try:
except ImportError:
np = None

if sys.version_info[:2] < (3, 8): # pragma: no cover
import pickle5 as pickle # nosec # pylint: disable=import_pickle
else:
import pickle # nosec # pylint: disable=import_pickle
import pickle # nosec # pylint: disable=import_pickle

cimport cython

Expand Down
2 changes: 0 additions & 2 deletions python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ def parse_version():
],
zip_safe=False,
install_requires=[
'dataclasses; python_version<"3.7"',
'pickle5; python_version<"3.8"',
"cloudpickle",
],
extras_require={
Expand Down

0 comments on commit 862667e

Please sign in to comment.