ci: integration test #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andresaiello please, review, thanks! |
andresaiello
reviewed
Oct 2, 2023
|
|
||
| if grep -E "^PRIVATE_KEY=[a-fA-F0-9]{64}$" .env; then | ||
| echo "The .env file contains a valid PRIVATE_KEY entry without the 0x prefix." | ||
| rm .env |
There was a problem hiding this comment.
You mean why have rm .env? The reason is in this section of the test I'm testing the key generation functionality, but I don't need the actual key for the rest of the test. I'm using a PRIVATE_KEY env variable stored in GitHub secrets, which has enough tokens (both native and ZETA) to deploy and test contracts. At some point I'll add faucet to the test, but I'll probably still keep using the evn variable, because I need native gETH, for example, which I can't get from a faucet.
andresaiello
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running some basic commands to ensure that the main bits are working fine.
--fees zeta