-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router contract example #214
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ot the same as sender
examples/nft/contracts/Connected.sol
Outdated
uint256 tokenId, | ||
string memory uri, | ||
uint256 gasAmount, | ||
address sender |
Check notice
Code scanning / Slither
Missing zero address validation Low
- (success,None) = sender.call{value: gasAmount}()
address receiver, | ||
uint256 amount, | ||
uint256 gasAmount, | ||
address sender |
Check notice
Code scanning / Slither
Missing zero address validation
Added an ability to use any supported ERC-20 token as a target token, e.g. from Ethereum call a contract on BNB with USDC. |
An example contact that routes cross-chain calls from one connected chain to another without you having to deploy a contract on ZetaChain.