Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated @ember/test-helpers to 4.0.2 and added it as a peer dependency #27

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

karl-sjogren
Copy link
Contributor

@karl-sjogren karl-sjogren commented Aug 28, 2024

@ember/test-helpers from version 4 needs to be added as a peer dependency in package.json or the following error will be shown.

@zestia/ember-dragula tried to import "@ember/test-helpers" in "@zestia/ember-dragula/test-support/helpers/simulate-drag-drop.js" from addon code, but "@ember/test-helpers" is a devDependency. You may need to move it into dependencies.

This was referenced in emberjs/ember-test-helpers#1490 in which there was a link to how they solved it in ember-scroll-modifiers. I've more or less copied their solution.

@amk221 amk221 merged commit 9a9040c into zestia:main Sep 3, 2024
1 of 3 checks passed
@amk221
Copy link
Contributor

amk221 commented Sep 3, 2024

Thanks.

Been a while since I've given this repo any TLC.

Can you try #28

@karl-sjogren
Copy link
Contributor Author

Sorry for the slow response @amk221, I've tried the 12.1.4-0 release and it works fine for me with both the 4.x and 3.x versions of @ember/test-helpers.

@amk221
Copy link
Contributor

amk221 commented Sep 5, 2024

Thanks! Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants