-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more styling options for users #108
base: main
Are you sure you want to change the base?
Conversation
Update .gitignore to ignore .idea files for Jetbrains users
Enhancing Styling FlexibilityOur current styling system, while functional, is limited. This approach, though practical for general applications, limits users who seek finer control over their styling preferences. To address this, I propose a more versatile styling mechanism. This would involve an optional builder pattern that allows users to customize styles by selectively overriding character sets at both the category and individual character levels. I would be happy to develop a prototype and further outline the potential interface. What do you think? I am ready to provide more details upon your interest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like a solid PR, much appreciated.
I'll definitely bear what you say in mind while working on ariadne's refactor also!
Ur working on a refactor? Cool. I have some time on my hands if you would like me to add some contributions. Also, on a side note how do you feel about a source code manipulation "Label" objects. For instance, if you want to prompt your reader to add something you could add an |
I have got an interface mostly complete for insertion, i can make a pull soon if interested. I think it should be relatively easy to place behind a feature flag |
My current progress is on the
Very positive! It's definitely planned for the refactor. I've not started implementing it yet, but my goal is to allow for the 'embellishment' of
I'd be interested to see how it compares with my own ideas about this for sure! |
Okay, ill make a pr into stable when im done with the feature so you can check it out.
Nice Nice. Ill check it out and see if I can help in the next week ish. |
Missclick 💀 |
Abstract
This pull request introduces the capability to use straight box drawing characters in addition to the existing curved ones. This enhancement broadens the range of visual styles available to users, allowing for greater flexibility and customization in graphical representations.
Background
Currently, our system supports only curved box drawing characters. While these are suitable for many applications, they can sometimes appear too stylized for use cases requiring a sharper, more angular aesthetic. Recognizing this limitation, this update provides an alternative that caters to different stylistic preferences and practical requirements.
Implementation Details
The implementation extends the existing functionality to include straight line variants of the box drawing characters. This is achieved by adding a new enumeration option,
CharSet::UnicodeStraight
, which users can select to switch from curved to straight line rendering. This option is designed to integrate seamlessly with the existing framework, ensuring that users can easily toggle between character styles without compatibility issues.Also Includes
.gitignore
to allow for better support for users of the Jetbrains IDEsCharSet::Unicode
&CharSet::UnicodeStright
Impact
By enabling the use of straight box drawing characters, this feature enhances the toolkit available to users, making it more adaptable to various design needs. It particularly benefits applications in design, text-based art, and user interface development, where line aesthetics can play a crucial role in user experience and information clarity.
Example