Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added necessary DT_DRV_COMPAT #define in akm09918 sensor decoder #72922

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

FlorianWeber1018
Copy link
Contributor

The sensor decoder api was not available in fact that there was a define missing which links the decoder api to the DT. This PR should fix this issue.

Copy link

Hello @FlorianWeber1018, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

ubieda
ubieda previously approved these changes May 17, 2024
@FlorianWeber1018
Copy link
Contributor Author

I have changed the commit so that the compliance checks should not fail now. Can anyone please restart the missing Tests?

yperess
yperess previously approved these changes May 28, 2024
Copy link
Collaborator

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine once CI passes

@MaureenHelm
Copy link
Member

Can you rebase please? It seems the twister status never returned and I don't see a way to retrigger it

Decoder api was not defined and lead to build error
if it is used in userland.
Fix that by adding necessary DT_DRV_COMPAT #define
in akm09918c sensor decoder.

Signed-off-by: Florian Weber <[email protected]>
@FlorianWeber1018
Copy link
Contributor Author

@MaureenHelm rebase is done

@henrikbrixandersen henrikbrixandersen merged commit 8f85255 into zephyrproject-rtos:main Jun 1, 2024
22 checks passed
Copy link

github-actions bot commented Jun 1, 2024

Hi @FlorianWeber1018!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants