tests/posix/env: set CONFIG_PICOLIBC=y #72917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: POSIX
cfriedt
reviewed
May 17, 2024
cfriedt
requested changes
May 17, 2024
cfriedt
previously approved these changes
May 21, 2024
cfriedt
reviewed
May 21, 2024
aescolar
force-pushed
the
test_posix_env_2
branch
2 times, most recently
from
11ed8b0
to
db155cd
Compare
Chosing by default in the prj.conf PICOLIBC ensures we also use an embedded libC even when built for a native target and even if we dont set POSIX_API. This ensures the test will build and pass properly when built with default configuration from command line without using the test yaml. This change does not affect the build result for other targets as those defaulted already to PICOLIBC. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
test_posix_env_2
branch
from
db155cd
to
96284f8
Compare
ycsin
reviewed
May 22, 2024
cfriedt
approved these changes
May 22, 2024
ycsin
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chosing by default in the prj.conf
PICOLIBC ensures we also use an embedded
libC even when built for a native target
and even if we dont set POSIX_API.
This ensures the test will build and pass
properly when built with default configuration
from command line without using the test yaml.
This change does not affect the build result
for other targets as those defaulted already
to PICOLIBC.