record: request deletion button #2419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitsosf
commented
Dec 5, 2022
•
mitsosf
commented
mitsosf
force-pushed
the
record_request_deletion
branch
6 times, most recently
from
91eadea
to
a267bb9
Compare
mitsosf
changed the title
mitsosf
force-pushed
the
record_request_deletion
branch
from
a267bb9
to
79c6548
Compare
mitsosf
force-pushed
the
record_request_deletion
branch
from
79c6548
to
db66870
Compare
slint
reviewed
Dec 12, 2022
| @@ -109,3 +154,45 @@ | |||
| </ul> | |||
| </div> | |||
| {%- endif %} | |||
|
|
|||
| <script> | |||
There was a problem hiding this comment.
Ideally, with the changes discussed IRL, we can completely remove JS since:
- there's no UI validation for the DOI typing
- the action is stored using cookies that expire in 1 week
There was a problem hiding this comment.
I am doing the cookie check with JS, because if I didn't I would have to modify the landing page view to check for the cookie and it seems excessive to me, let's discuss IRL, maybe I'm forgetting parts of our last discussion.
Comment on lines
+583
to
+588
| if request.form['expected-doi'] != request.form['record-doi']: | ||
| flash(_("The DOI you typed did not match the record's DOI."), | ||
| category='warning') | ||
| return redirect(url_for("invenio_records_ui.recid", pid_value=record[ | ||
| 'recid'])) | ||
|
|
There was a problem hiding this comment.
Can you remind me why we decided to skip this? :)
mitsosf
force-pushed
the
record_request_deletion
branch
from
db66870
to
488d41b
Compare
|
Before this goes live we need to see how we will be handling DOIs not managed by us, eg provide a perpetual option for deletion. Or simplify things code-wise by having the users go through the support line if the record is older than 30 days? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.