Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

records-ui: GitHub branding showing up twice zenodo#2001 #2205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

records-ui: GitHub branding showing up twice zenodo#2001 #2205

wants to merge 1 commit into from
+5 −2

Conversation

ines-cruz
Copy link
Contributor

closes #2001

I added 3 GitHub repo's to the test recod and only one GitHub branding shows as shown in the pic

askAlex1

@ines-cruz
Copy link
Contributor Author

I have a question regarding this issue.
I added 3 GitHub repos as supplement of the test record and it showed 3 banners of GitHub, one per repo i added as supplement. Like this, it only has the banner once, for the first supplement repo. I dont think this is a problem because we still have the 3 links to the repos (seen bellow in the pic) but is this how we intend it to be?
Should that branding of GitHub link to a supplement repo or to the repo of the record?
Thanks!

@ines-cruz ines-cruz requested a review from slint August 21, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint Awaiting requested review from slint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

records-ui: GitHub branding showing up twice
1 participant
@ines-cruz