Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vehicle loadout context actions #554

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add vehicle loadout context actions #554

wants to merge 7 commits into from

Conversation

neilzar
Copy link
Contributor

@neilzar neilzar commented Feb 13, 2021

When merged this pull request will:

  • Title

@neilzar neilzar added the feature Adds a new feature label Feb 13, 2021
@neilzar neilzar added this to the 1.11.0 milestone Feb 13, 2021
@neilzar
Copy link
Contributor Author

neilzar commented Feb 15, 2021 •
edited
Loading

I'm not sure about the icons. If anyone has any ideas/can make some, that would help a lot.

@neilzar neilzar marked this pull request as ready for review March 11, 2021 15:03
@ampersand38
Copy link
Member

ampersand38 commented Mar 11, 2021 •
edited
Loading

How about these?
alpha inverted a3\ui_f\data\GUI\Cfg\Hints\AmmoType_CA.paa
ammoType_ca

combo alpha inverted a3\ui_f_jets\Data\GUI\Cfg\Hints\WeaponsBombs_ca.paa and a3\ui_f_jets\Data\GUI\Cfg\Hints\WeaponsMissiles_ca.paa
pylonStores_ca

@neilzar
Copy link
Contributor Author

neilzar commented Mar 11, 2021

Those are nice, but would create inconsistency with the magazine icon.

@ampersand38
Copy link
Member

I meant for the ammo-type to be used for magazine, and bomb/missile to be used for pylon.

@neilzar
Copy link
Contributor Author

neilzar commented Mar 11, 2021

I'm not sure the one for magazine is clear enough, in that case. Too much detail to be noticeable in the context menu, and doesn't represent any mg ammo.

mharis001
mharis001 reviewed Mar 13, 2021
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add zen_loadout and zen_pylons to requiredAddons[].

addons/context_actions/functions/fnc_canEditMagazines.sqf Outdated Show resolved Hide resolved
addons/context_actions/functions/fnc_canEditPylons.sqf Outdated Show resolved Hide resolved
@neilzar neilzar requested a review from mharis001 March 13, 2021 12:06
@neilzar neilzar requested a review from mharis001 March 14, 2021 13:12
mharis001
mharis001 reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. I'd like to see these actions follow the standard "Edit"/"Copy"/"Paste" scheme we have for other actions of this type. Should be fairly straightforward to add; only obstacle would be dealing with default pylon weapons when setting the pylon loadout.

addons/context_actions/CfgContext.hpp
displayName = ECSTRING(pylons,DisplayName);
condition = QUOTE(_hoveredEntity call FUNC(canEditPylons));
statement = QUOTE(_hoveredEntity call EFUNC(pylons,configure));
icon = "\a3\ui_f\data\igui\cfg\weaponicons\aa_ca.paa";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think use the jets icon for pylons.

@mharis001 mharis001 modified the milestones: 1.11.0, 1.12.0 Jun 16, 2021
@mharis001 mharis001 modified the milestones: 1.12.0, 1.13.0 Sep 3, 2021
@mharis001 mharis001 modified the milestones: 1.13.0, Backlog Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 left review comments

@CreepPork CreepPork CreepPork approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@neilzar @ampersand38 @CreepPork @mharis001