Add Saved selection for modules and Transfer Ownership Module #501

ampersand38 · 2021-01-09T19:42:07Z

When merged this pull request will:

Add global variable zen_editor_savedSelection which tracks the previous-to-last content of curatorSelected, used for selecting entities then dropping a module affecting them.
Add Transfer Ownership module using saved selection
https://youtu.be/4L-czAJIIcQ
https://youtu.be/sAHKlZA-Vz4

Kexanone · 2021-01-10T19:26:53Z

~~Can you enable edits from maintainers?~~
~~Wanted to add the revised selection preview.~~
Nvm, I was just stupid.

…EN into save-selection-for-modules

jonpas · 2021-01-11T09:57:57Z

Is that naked unit bug fix basically same as in ACEX Headless or did you improve it in any way?

Side-note: It would be nice to have ACEX Headless compatibility when transfering to client (automatically put into headless blacklist for automatic transfers). Or an API event to be able to do it in a mission framework for example.

Kexanone · 2021-01-11T10:03:04Z

Is that naked unit bug fix basically same as in ACEX Headless or did you improve it in any way?

Oh, I forgot about the ACEX one. I basically improved the Achilles' version of the fix by switching to unscheduled and reducing network traffic by not broadcasting the loadouts to all clients.

Side-note: It would be nice to have ACEX Headless compatibility when transfering to client (automatically put into headless
blacklist for automatic transfers). Or an API event to be able to do it in a mission framework for example.

Yeah, we still have to look into this.

jonpas · 2021-01-11T10:10:39Z

I basically improved the Achilles' version of the fix by switching to unscheduled and reducing network traffic by not broadcasting the loadouts to all clients.

ACEX Headless does transmit loadout to everyone as well, and that is for sure an improvement in network traffic. But I don't see how it can be enough of an improvement to "fix" the issue, not while there are a million way more intensive things being broadcasted.

This seems to be a possible better fix (which I haven't implemented in ACEX yet): acemod/ACEX#180 (comment) (also ref. linked BI ticket).

We also haven't really experienced this issue since the first fix implementation in ACEX, so I am mostly putting it down to badly optimized missions/mods.

Kexanone · 2021-01-11T10:29:07Z

ACEX Headless does transmit loadout to everyone as well, and that is for sure an improvement in network traffic. But I don't see how it can be enough of an improvement to "fix" the issue, not while there are a million way more intensive things being broadcasted.

I agree with that, but the more important improvement of the new implementation is that the loadouts are guaranteed to be defined when you restore them. Achilles did not check and wait for the loadouts broadcasted via public setVariable to be defined on the new owner.

jonpas · 2021-01-11T10:45:28Z

Ah I see what you mean. That's actually a pretty good point.

Kexanone · 2021-01-11T11:37:36Z

Actually, seeing now the ACEX implementation. The local EH combined with the appropriate checks via CBA_fnc_waitUntilAndExecute could be the best approach to tackle this problem in a general way. At this point, why not provide a common fix for all of us with CBA?

jonpas · 2021-01-11T12:19:24Z

At this point, why not provide a common fix for all of us with CBA?

Sure, I think that would be in scope. Want to open a PR?

Kexanone · 2021-01-11T12:24:57Z

Sure, I think that would be in scope. Want to open a PR?

Yeah, I'll work on one when I got time.
Would fit nicely into the new characters addon if you merge CBATeam/CBA_A3#1344 ;)

jonpas · 2021-01-11T13:36:12Z

Awesome! 👍

Yeah, it's tagged for 3.16. But things are slow in this age of Arma 3.

This reverts commit bb41331.

Kexanone · 2021-01-11T21:01:55Z

Reverted the fix in favor of CBATeam/CBA_A3#1406

ampersand38 · 2021-01-12T00:51:34Z

addons/modules/functions/fnc_moduleTransferOwnership.sqf

addons/editor/functions/fnc_toggleSelectionPreview.sqf

addons/modules/functions/fnc_moduleTransferOwnership.sqf

addons/editor/functions/fnc_handleSelectionChanged.sqf

mharis001 · 2021-01-21T23:40:00Z

addons/editor/functions/fnc_handleSelectionChanged.sqf

+ * 0: Entity: group, marker, object, or waypoint <GROUP, STRING, OBJECT, ARRAY>
+ *
+ * Return Value:
+ * Handled <BOOL>


Can this event handler be overridden?

No, we don't store the index of the event anywhere, but we did the same for all other curator event handlers. We could consider bridging them with CBA event handlers, but I would make a separate PR for such a change.

Target: if remote then curator else if HCs then HC else server HC scripts: if default going to HC then enabled, else disabled

ampersand38 · 2021-01-25T19:54:15Z

https://youtu.be/sAHKlZA-Vz4

…r-modules

addons/modules/functions/fnc_moduleTransferOwnership.sqf

CreepPork · 2021-03-04T08:19:41Z

addons/modules/functions/fnc_moduleTransferOwnership.sqf

+    ],
+    [
+        "TOOLBOX",
+        LSTRING(ModuleTransferOwnership_HCScripts),


Tooltip, at least, please? What is a HC script? To an end-user, no idea what this is and why I should enable it or disable it. And why is this a toggle, if it does something good why not auto it?

It does auto-select based on the current locality:

If local, assume target will be HC and balancing will be enabled.

If remote, assume target will be Curator and balancing will be disabled.
However I wanted to let user pick for edge cases.

What else can we do to make it easier to understand and use?
a1696ce

Co-authored-by: Ralfs Garkaklis <[email protected]>

mharis001

I would like to see this feature moved to its own component so it is easier to work on in the future. editor component already has a lot of responsibilities and it will be difficult to see everything involved in making this work.

mharis001 · 2021-04-20T02:43:57Z

addons/common/XEH_postInit.sqf

+    [QGVAR(transferOwnership), {
+        params ["_entities", "_target"];
+        if (!(_entities isEqualType [])) then {
+            _entities = [_entities];
+        };
+        private _clientID = 0;
+        if (_target isEqualType 0) then {
+            _clientID = _target;
+        };
+        if (_target isEqualType objNull) then {
+            _clientID = owner _target;
+        };
+        {
+            if (_x isEqualType grpNull) then {
+                _x setGroupOwner _clientID;
+            } else {
+                if (group _x == grpNull) then {
+                    _x setOwner _clientID;
+                } else {
+                    group _x setGroupOwner _clientID;
+                };
+            };
+        } forEach _entities;
+    }] call CBA_fnc_addEventHandler;


I think this is big enough to warrant moving into a function/separate file.

mharis001 · 2021-04-20T02:46:32Z

addons/modules/functions/fnc_moduleTransferOwnership.sqf

+        "TOOLBOX",
+        [LSTRING(ModuleTransferOwnership_HCScripts), LSTRING(ModuleTransferOwnership_HCScripts_Description)],
+        [parseNumber (_defaultTarget == 2), 1, 2, [
+            ELSTRING(common,Disabled),
+            ELSTRING(common,Enabled)
+        ]],
+        true


Use TOOLBOX:ENABLED here.

mharis001 · 2021-04-20T02:47:27Z

addons/editor/functions/fnc_toggleSelectionPreview.sqf

+                {
+                    drawIcon3D [
+                        GVAR(lastModuleIcon),
+                        GVAR(colour), getPosVisual _x, 1, 1, 0


getPosVisual returns AGLS, drawIcon3D expects AGL.

ampersand38 added 5 commits January 9, 2021 02:08

Saved Selection and Transfer Ownership

4d6fd85

Toolbox for most Server and Curator targets

92f5c61

Check for players in selection

c85e34f

Added module description

6b84b80

remove logging

40adda7

Kexanone added this to the 1.10.0 milestone Jan 9, 2021

Kexanone added the feature Adds a new feature label Jan 9, 2021

Improved selection preview

3f4bcc2

ampersand38 and others added 5 commits January 10, 2021 16:11

Force toolbox default value

344c9d3

Clean-up

ebffcfc

Merge branch 'save-selection-for-modules' of github-kex:ampersand38/Z…

f60054c

…EN into save-selection-for-modules

Add default value for icon cache

46a32a3

Naked unit bug fix

bb41331

Revert "Naked unit bug fix"

c7d75d7

This reverts commit bb41331.

add toolbox for hc scripts flags

2a07065

jonpas reviewed Jan 12, 2021

View reviewed changes

addons/modules/functions/fnc_moduleTransferOwnership.sqf Outdated Show resolved Hide resolved

Kexanone mentioned this pull request Jan 13, 2021

Feature Request: Selection of multiple sets of units/groups #503

Open

Update stringtable.xml

84a8872

mharis001 requested changes Jan 21, 2021

View reviewed changes

Kexanone added 8 commits January 23, 2021 18:14

Use a single handler for selection icons

2124725

Fix syntax

46b755e

Remove _mehID

d9d8308

Single delete logic

e6a09c9

Doc comment

8feb8a7

Remove correct event handler

6b5755d

Merge options

98916d6

Sort player targets by name

e10c311

Kexanone requested a review from mharis001 January 23, 2021 19:22

Kexanone and others added 2 commits January 24, 2021 00:56

Prioritize HCs

f6a5055

Change default values

e6fe9bb

Target: if remote then curator else if HCs then HC else server HC scripts: if default going to HC then enabled, else disabled

mharis001 modified the milestones: 1.10.0, 1.11.0 Feb 3, 2021

neilzar approved these changes Feb 3, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into save-selection-fo…

5b458c4

…r-modules

CreepPork reviewed Mar 4, 2021

View reviewed changes

ampersand38 and others added 3 commits March 4, 2021 10:51

Update addons/modules/functions/fnc_moduleTransferOwnership.sqf

7d0f755

Co-authored-by: Ralfs Garkaklis <[email protected]>

use select

7e3f1d1

Tooltip

a1696ce

CreepPork approved these changes Apr 15, 2021

View reviewed changes

mharis001 requested changes Apr 20, 2021

View reviewed changes

mharis001 modified the milestones: 1.11.0, 1.12.0 Jun 14, 2021

mharis001 modified the milestones: 1.12.0, 1.13.0 Sep 3, 2021

mharis001 modified the milestones: 1.13.0, Backlog Apr 28, 2022

Quailsnap mentioned this pull request May 4, 2022

Headless Client Blacklist Button #668

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Saved selection for modules and Transfer Ownership Module #501

Add Saved selection for modules and Transfer Ownership Module #501

ampersand38 commented Jan 9, 2021 •

edited

Loading

Kexanone commented Jan 10, 2021 •

edited

Loading

jonpas commented Jan 11, 2021 •

edited

Loading

Kexanone commented Jan 11, 2021 •

edited

Loading

jonpas commented Jan 11, 2021 •

edited

Loading

Kexanone commented Jan 11, 2021

jonpas commented Jan 11, 2021

Kexanone commented Jan 11, 2021

jonpas commented Jan 11, 2021

Kexanone commented Jan 11, 2021

jonpas commented Jan 11, 2021

Kexanone commented Jan 11, 2021

ampersand38 commented Jan 12, 2021

mharis001 Jan 21, 2021

Kexanone Jan 23, 2021

ampersand38 commented Jan 25, 2021

CreepPork Mar 4, 2021 •

edited

Loading

ampersand38 Mar 4, 2021 •

edited

Loading

mharis001 left a comment

mharis001 Apr 20, 2021

mharis001 Apr 20, 2021

mharis001 Apr 20, 2021

Add Saved selection for modules and Transfer Ownership Module #501

Are you sure you want to change the base?

Add Saved selection for modules and Transfer Ownership Module #501

Conversation

ampersand38 commented Jan 9, 2021 • edited Loading

Kexanone commented Jan 10, 2021 • edited Loading

jonpas commented Jan 11, 2021 • edited Loading

Kexanone commented Jan 11, 2021 • edited Loading

jonpas commented Jan 11, 2021 • edited Loading

Kexanone commented Jan 11, 2021

jonpas commented Jan 11, 2021

Kexanone commented Jan 11, 2021

jonpas commented Jan 11, 2021

Kexanone commented Jan 11, 2021

jonpas commented Jan 11, 2021

Kexanone commented Jan 11, 2021

ampersand38 commented Jan 12, 2021

mharis001 Jan 21, 2021

Choose a reason for hiding this comment

Kexanone Jan 23, 2021

Choose a reason for hiding this comment

ampersand38 commented Jan 25, 2021

CreepPork Mar 4, 2021 • edited Loading

Choose a reason for hiding this comment

ampersand38 Mar 4, 2021 • edited Loading

Choose a reason for hiding this comment

mharis001 left a comment

Choose a reason for hiding this comment

mharis001 Apr 20, 2021

Choose a reason for hiding this comment

mharis001 Apr 20, 2021

Choose a reason for hiding this comment

mharis001 Apr 20, 2021

Choose a reason for hiding this comment

ampersand38 commented Jan 9, 2021 •

edited

Loading

Kexanone commented Jan 10, 2021 •

edited

Loading

jonpas commented Jan 11, 2021 •

edited

Loading

Kexanone commented Jan 11, 2021 •

edited

Loading

jonpas commented Jan 11, 2021 •

edited

Loading

CreepPork Mar 4, 2021 •

edited

Loading

ampersand38 Mar 4, 2021 •

edited

Loading