Add Unpack Static Weapon module #378

ampersand38 · 2020-05-14T04:31:46Z

When merged this pull request will:

Add module to make AI static weapons teams unpack their weapons and set it up facing the target position
unpack function can be used in waypoints etc
https://www.youtube.com/watch?v=DvvJPq0wsCI

BrettMayson · 2020-05-14T05:26:15Z

I think there should be some settings added here, maybe one for max range between the two units. It would also be interesting to see if we could get the assistant to go to the gunner if they are outside that range.

CreepPork · 2020-05-14T07:32:53Z

@ampersand38
Use a text editor that supports the .editorconfig file. It seems that your editor is using tabs not spaces which is disallowed.

addons/modules/functions/fnc_moduleFireLauncher.sqf

ampersand38 · 2020-05-14T15:33:27Z

I think there should be some settings added here, maybe one for max range between the two units. It would also be interesting to see if we could get the assistant to go to the gunner if they are outside that range.

Ah! I'm just learning about editorconfig now. Will try again to get it to work. Thanks.

addons/modules/XEH_PREP.hpp

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

addons/modules/functions/fnc_unpackStaticWeapon.sqf

ampersand38 · 2020-05-17T04:27:32Z

Much appreciated for the review @CreepPork. I'll aim to adhere to the standards.

ampersand38 · 2020-05-21T17:36:11Z

I think there should be some settings added here, maybe one for max range between the two units. It would also be interesting to see if we could get the assistant to go to the gunner if they are outside that range.

I haven't had a lot of success getting the weapon carriers to move together while under fire, even when pulling apart something like https://github.com/acemod/ACE3/blob/master/addons/ai/functions/fnc_garrisonMove.sqf

It may be a case of "don't use this when players can clearly observe that the ai can't do this".

mharis001

Currently looks weird having the gunner and assistant apart from each other. Should definitely try to get them to move towards each other.

Maybe have the gunner perform an action to get in the turret instead of immediately moving them in.

addons/ai/functions/fnc_unpackStaticWeapon.sqf

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

addons/ai/functions/fnc_unpackStaticWeapon.sqf

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

ampersand38 · 2020-06-23T18:14:32Z

Currently looks weird not having the gunner and assistant apart from each other. Should definitely try to get them to move towards each other.

I seem to have this working!

Maybe have the gunner perform an action to get in the turret instead of immediately moving them in.

When I use orderGetIn the AI just run a little circle and then teleport in anyway. It seems there's no getIn animation for these turrets.

https://youtu.be/6h9xUblJzlI

mharis001

Works a little bit better in combat but, still fails in some situations. Maybe try using setBehaviour and setCombatMode on the group.

Also, currently you do some handling for the weapon assembly in the module's function (movement, behaviour) and some in unpackStaticWeapon. All of it should be handled in unpackStaticWeapon, the module should just call the ai component's function.

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

ampersand38 · 2020-06-29T15:47:24Z

Works a little bit better in combat but, still fails in some situations. Maybe try using setBehaviour and setCombatMode on the group.

Also, currently you do some handling for the weapon assembly in the module's function (movement, behaviour) and some in unpackStaticWeapon. All of it should be handled in unpackStaticWeapon, the module should just call the ai component's function.

I didn't want to stop the rest of the group from firing, so I'm having the assistant join his own group and managing behaviour from there.

I've also moved the pfh to the AI addon.

addons/ai/functions/fnc_unpackStaticWeapon.sqf

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

mharis001

The weapon assembly works consistently now both in and out of combat 👍 . However, the gunner will sometimes not get into the weapon when in combat. May need to switch back to using moveInGunner to make that work.

Also, should add the static weapon to curator editable objects.

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

addons/modules/stringtable.xml

mharis001

Looks good. Just some code cleanup.

A bit weird in terms of structure that unpackStaticWeaponPFH is called first. I think it should be the other way around where unpackStaticWeapon deals with all of the setup and starting the PFH if needed.

addons/ai/functions/fnc_unpackStaticWeapon.sqf

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

addons/ai/functions/fnc_unpackStaticWeapon.sqf

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

mharis001 · 2020-08-25T04:03:58Z

Pushing to 1.10 since I think there is some cleanup left to do as well as consider:

groups with players.
single backpack static weapons.
selecting the closest assistant if multiple are possible.

Co-authored-by: Ralfs Garkaklis <[email protected]>

Bummeri · 2020-10-12T19:42:16Z

Deploy_static.zip

You can use that potrait if you like for the module

- Dropping module on unit in the same group as a player will only show a message - Single-bag weapons such as UAVs and Remote Designators are now supported - Check all compatible assistants and choose the closest one - Error msg if closest assistant is over 100m away since it would probably take too long

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

Co-authored-by: NeilZar <[email protected]>

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

Co-authored-by: Ralfs Garkaklis <[email protected]>

mharis001 · 2021-06-14T22:03:51Z

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

+private _group = group _assistant;
+_group setBehaviourStrong "CARELESS";
+_group deleteGroupWhenEmpty true;
+_group enableAttack false;


Can probably use new setCombatBehaviour and setUnitCombatMode commands to avoid affecting the entire group. Also, likely make units more responsive even in combat.

mharis001 · 2021-06-14T22:04:11Z

addons/ai/functions/fnc_unpackStaticWeapon.sqf

+    [QEGVAR(common,addObjects), [[_weapon]]] call CBA_fnc_serverEvent;
+
+    private _targetPos = _gunner getVariable [QGVAR(unpackStaticWeaponTargetPos), []];
+    if (!(_targetPos isEqualTo [])) then {


isNotEqualTo.

mharis001 · 2021-06-14T22:04:24Z

addons/ai/functions/fnc_unpackStaticWeapon.sqf

+    [_gunner, _assistant, _targetPos] call FUNC(unpackStaticWeaponPFH);
+};
+
+if (!(_targetPos isEqualTo [])) then {


isNotEqualTo.

mharis001 · 2021-06-14T22:04:26Z

addons/ai/functions/fnc_unpackStaticWeapon.sqf

+    [QGVAR(unpackStaticWeapon), _this, _gunner] call CBA_fnc_targetEvent;
+};
+
+if (!(_targetPos isEqualTo [])) then {


isNotEqualTo.

mharis001 · 2021-06-14T22:04:41Z

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

+
+private _assembleInfo = ["assembleTo", "base", "displayName", "dissasembleTo", "primary"] apply {(configOf backpackContainer _gunner >> "assembleInfo" >> _x) call BIS_fnc_getCfgData};
+_assembleInfo params ["_assembleTo", "_compatibleBases", "_displayName", "_dissasembleTo", "_primary"];
+if (_compatibleBases isEqualType "") then {_compatibleBases = [];};


Multi-line.

mharis001 · 2021-06-14T22:09:51Z

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

+
+private _assembleInfo = ["assembleTo", "base", "displayName", "dissasembleTo", "primary"] apply {(configOf backpackContainer _gunner >> "assembleInfo" >> _x) call BIS_fnc_getCfgData};
+_assembleInfo params ["_assembleTo", "_compatibleBases", "_displayName", "_dissasembleTo", "_primary"];
+if (_compatibleBases isEqualType "") then {_compatibleBases = [];};


Is this correct? the base config entry is text when there is only one compatible base but this line makes it so there are none.

mharis001 · 2021-06-14T22:11:01Z

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

+    {
+        if (
+            // Has matching backpack
+            (backpack _x in _compatibleBases || {_backpack in ((configOf backpackContainer _x >> "assembleInfo" >> "base") call BIS_fnc_getCfgData)})


The base config entry is not guaranteed to be an array.

mharis001 · 2021-06-14T22:12:28Z

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

+_assembleInfo params ["_assembleTo", "_compatibleBases", "_displayName", "_dissasembleTo", "_primary"];
+if (_compatibleBases isEqualType "") then {_compatibleBases = [];};
+
+if (_primary == 1 && {_compatibleBases isEqualTo [] || {_compatibleBases isEqualTo "" || {_compatibleBases isEqualTo [""]}}}) then {


_compatibleBases cannot be a string at this point. Line 50 changes it to an array.

mharis001 · 2021-06-14T22:13:21Z

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

+                [QEGVAR(common,addObjects), [[_weapon]]] call CBA_fnc_serverEvent;
+
+                private _targetPos = _gunner getVariable [QGVAR(unpackStaticWeaponTargetPos), []];
+                if (!(_targetPos isEqualTo [])) then {


isNotEqualTo.

mharis001 · 2021-06-14T22:16:30Z

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

+            // Has matching backpack
+            (backpack _x in _compatibleBases || {_backpack in ((configOf backpackContainer _x >> "assembleInfo" >> "base") call BIS_fnc_getCfgData)})
+            // Closer than current
+            && {_assistant == objNull || {(_gunner distance _x) < (_gunner distance _assistant)}}


CreepPork added the feature Adds a new feature label May 14, 2020

CreepPork added this to the 1.8.0 milestone May 14, 2020

CreepPork requested changes May 14, 2020

View reviewed changes

addons/modules/functions/fnc_moduleFireLauncher.sqf Outdated Show resolved Hide resolved

CreepPork requested changes May 15, 2020

View reviewed changes

mharis001 modified the milestones: 1.8.0, 1.9.0 May 19, 2020

ampersand38 requested a review from CreepPork May 26, 2020 23:17

ampersand38 force-pushed the Unpack-Static-Weapon branch from fae0efc to 4b9c790 Compare June 8, 2020 16:35

mharis001 reviewed Jun 14, 2020

View reviewed changes

mharis001 reviewed Jun 27, 2020

View reviewed changes

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf Outdated Show resolved Hide resolved

CreepPork requested changes Jul 6, 2020

View reviewed changes

addons/ai/functions/fnc_unpackStaticWeapon.sqf Outdated Show resolved Hide resolved

addons/ai/functions/fnc_unpackStaticWeapon.sqf Outdated Show resolved Hide resolved

addons/ai/functions/fnc_unpackStaticWeapon.sqf Outdated Show resolved Hide resolved

ampersand38 requested a review from CreepPork July 7, 2020 16:56

CreepPork requested changes Jul 23, 2020

View reviewed changes

addons/ai/functions/fnc_unpackStaticWeapon.sqf Outdated Show resolved Hide resolved

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf Outdated Show resolved Hide resolved

addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf Outdated Show resolved Hide resolved

mharis001 reviewed Jul 28, 2020

View reviewed changes

mharis001 reviewed Aug 5, 2020

View reviewed changes

CreepPork reviewed Aug 21, 2020

View reviewed changes

mharis001 modified the milestones: 1.9.0, 1.10.0 Aug 25, 2020

ampersand38 added 4 commits August 31, 2020 11:39

Add Unpack Static Weapon module

450aeac

Extraneous file deleted

e5c9938

Tabs to spaces

70caa97

Update fnc_unpackStaticWeapon.sqf

569249c

ampersand38 and others added 2 commits August 31, 2020 11:39

Update addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

2f167e9

Co-authored-by: Ralfs Garkaklis <[email protected]>

new line before return value

2cfb05c

ampersand38 force-pushed the Unpack-Static-Weapon branch from 6055271 to 2cfb05c Compare August 31, 2020 15:39

ampersand38 added 2 commits December 18, 2020 17:42

New Icon

0db8c1e

ampersand38 requested a review from CreepPork December 18, 2020 22:47

Removed < in text

aea37ab

neilzar requested changes Jan 13, 2021

View reviewed changes

addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf Outdated Show resolved Hide resolved

findIf instead of count

1bd1ba0

Co-authored-by: NeilZar <[email protected]>

mharis001 modified the milestones: 1.10.0, 1.11.0 Feb 3, 2021

CreepPork reviewed Mar 4, 2021

View reviewed changes

ampersand38 and others added 9 commits March 4, 2021 09:05

Update addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

6a41922

Co-authored-by: Ralfs Garkaklis <[email protected]>

Update addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

a4df41c

Co-authored-by: Ralfs Garkaklis <[email protected]>

Update addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

96e8a82

Co-authored-by: Ralfs Garkaklis <[email protected]>

Update addons/ai/functions/fnc_unpackStaticWeaponPFH.sqf

69b1da8

Co-authored-by: Ralfs Garkaklis <[email protected]>

Update addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

e1e006d

Co-authored-by: Ralfs Garkaklis <[email protected]>

Update addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

73aa57c

Co-authored-by: Ralfs Garkaklis <[email protected]>

Update addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

398c5d2

Co-authored-by: Ralfs Garkaklis <[email protected]>

Update addons/modules/functions/fnc_moduleUnpackStaticWeapon.sqf

dd78720

Co-authored-by: Ralfs Garkaklis <[email protected]>

remove commented code

bc929a2

mharis001 requested changes Jun 14, 2021

View reviewed changes

mharis001 modified the milestones: 1.11.0, 1.12.0 Jun 14, 2021

Merge branch 'master' into Unpack-Static-Weapon

0d34257

mharis001 modified the milestones: 1.12.0, 1.13.0 Sep 3, 2021

mharis001 modified the milestones: 1.13.0, Backlog Apr 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Unpack Static Weapon module #378

Add Unpack Static Weapon module #378

ampersand38 commented May 14, 2020

BrettMayson commented May 14, 2020 •

edited

Loading

CreepPork commented May 14, 2020

ampersand38 commented May 14, 2020

ampersand38 commented May 17, 2020

ampersand38 commented May 21, 2020

mharis001 left a comment •

edited

Loading

ampersand38 commented Jun 23, 2020

mharis001 left a comment

ampersand38 commented Jun 29, 2020

mharis001 left a comment

mharis001 left a comment

mharis001 commented Aug 25, 2020

Bummeri commented Oct 12, 2020

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

mharis001 Jun 14, 2021

Add Unpack Static Weapon module #378

Are you sure you want to change the base?

Add Unpack Static Weapon module #378

Conversation

ampersand38 commented May 14, 2020

BrettMayson commented May 14, 2020 • edited Loading

CreepPork commented May 14, 2020

ampersand38 commented May 14, 2020

ampersand38 commented May 17, 2020

ampersand38 commented May 21, 2020

mharis001 left a comment • edited Loading

Choose a reason for hiding this comment

ampersand38 commented Jun 23, 2020

mharis001 left a comment

Choose a reason for hiding this comment

ampersand38 commented Jun 29, 2020

mharis001 left a comment

Choose a reason for hiding this comment

mharis001 left a comment

Choose a reason for hiding this comment

mharis001 commented Aug 25, 2020

Bummeri commented Oct 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrettMayson commented May 14, 2020 •

edited

Loading

mharis001 left a comment •

edited

Loading