Add a case for shadows when blur_radius = 0 #22441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
iamnbutler
added
macOS
jansol
reviewed
Dec 27, 2024
| float distance = length(max(float2(0., 0.), rounded_edge_to_point)) + | ||
| min(0., max(rounded_edge_to_point.x, rounded_edge_to_point.y)) - | ||
| corner_radius; | ||
| alpha = distance <= 0. ? 1. : 0.; |
There was a problem hiding this comment.
Does metal have something like the GLSL smoothstep()? With appropriate threshold values using that instead of the hard conditional here should fix the aliased edges nicely.
There was a problem hiding this comment.
oh, I'll take a look!
There was a problem hiding this comment.
Alternatively a simple alpha = (1.0 - min(1.0, distance * distance)) should look good too.
|
Blade shaders are directly transcribed from the metal ones so they'll need the same fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22433
Before/After (macOS):
For some reason the non-blurred one seems much lower quality, so we may need to tinker with the samples, or something else.
I'm unsure if this is a problem on Linux/in the Blade renderer, but since no changes were made outside of the medal shaders we can probably take this macOS-specific win for now.
Release Notes:
blur_radiusof 0 would not render.