Add fine-grained control for scrollbar diagnostics #22364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Could we make this setting backwards compatible? Accept both true/false and the enum? |
|
@mikayla-maki: I was hoping to do that and tried using deserialization aliasing, but couldn't figure it out. Any thoughts on how? |
AaronFeickert
force-pushed
the
scrollbar-diagnostic-level
branch
2 times, most recently
from
4f1f668 to
6880a3b
Compare
|
@mikayla-maki: this has been updated to make the diagnostic level setting separate, in order to avoid a breaking change. |
AaronFeickert
force-pushed
the
scrollbar-diagnostic-level
branch
from
6880a3b to
40c30a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a scrollbar diagnostic level setting to provide fine-grained control over which indicators to show, based on severity level. This allows the user to hide lower-severity diagnostics that can otherwise clutter the scrollbar (for example, unused or disabled code).
Closes #22296.
Release Notes: