ruby: Make ruby-lsp the default LSP for Ruby
#22312
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
vitallium
force-pushed
the
vs/ruby-make-ruby-lsp-default
branch
from
471eb6d to
1798ca0
Compare
vitallium
changed the title
ruby-lsp the default LSP for Rubyruby-lsp the default LSP for Ruby
|
Solargraph hasn't been maintained for a long time, and ruby-lsp is stable enough for now. But ruby-lsp uses pull-based diagnostics which Zed doesn't support yet. We need to disable the diagnostics feature of ruby-lsp and set rubocop as the diagnostics lsp server. BTW, I'm a bit curious why zed still doesn't support pull-based diagnostics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ruby-lspthe default LSP for Ruby. I believeruby-lspis now mature enough to become the default LSP for the Ruby language. Despite all my love forsolargraph, its development has stalled (last commit 10 months ago), and perhaps it's time to replace it withruby-lsp.Release Notes: